remove debugging

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

Author: saishreeeee

.github/workflows/code-quality-checks.yml

@@ -112,7 +112,7 @@ jobs:
       #              run test suite
       #----------------------------------------------
       -   name: Run tests
-          run: poetry run python -m pytest tests/unit 
+          run: poetry run python -m pytest tests/unit
   check-linting:
     runs-on: ubuntu-latest
     strategy:

src/databricks/sql/telemetry/telemetry_client.py

@@ -387,6 +387,7 @@ def _install_exception_hook(cls):
     def _handle_unhandled_exception(cls, exc_type, exc_value, exc_traceback):
         """Handle unhandled exceptions by sending telemetry and flushing thread pool"""
         logger.debug("Handling unhandled exception: %s", exc_type.__name__)
+
         clients_to_close = list(cls._clients.values())
         for client in clients_to_close:
             client.close()
@@ -403,6 +404,7 @@ def initialize_telemetry_client(
         host_url,
     ):
         """Initialize a telemetry client for a specific connection if telemetry is enabled"""
+
         try:
             with TelemetryClientFactory._lock:
                 TelemetryClientFactory._initialize()
@@ -450,6 +452,7 @@ def get_telemetry_client(session_id_hex):
     @staticmethod
     def close(session_id_hex):
         """Close and remove the telemetry client for a specific connection"""
+
         with TelemetryClientFactory._lock:
             if (
                 telemetry_client := TelemetryClientFactory._clients.pop(

src/databricks/sql/thrift_backend.py

@@ -42,7 +42,6 @@
 )
 from databricks.sql.types import SSLOptions
 
-
 logger = logging.getLogger(__name__)
 
 unsafe_logger = logging.getLogger("databricks.sql.unsafe")

tests/unit/test_client.py

@@ -83,44 +83,6 @@ class ClientTestSuite(unittest.TestCase):
         "access_token": "tok",
     }
 
-    # def setUp(self):
-    #     """Set up connection tracking before each test"""
-    #     self.tracked_connections = []
-        
-    #     # Store the original connect function
-    #     self.original_connect = databricks.sql.connect
-        
-    #     def patched_connect(*args, **kwargs):
-    #         """Wrapper that tracks all created connections"""
-    #         conn = self.original_connect(*args, **kwargs)
-            
-    #         # Skip tracking for finalizer tests to allow garbage collection
-    #         if not (hasattr(self, '_testMethodName') and 'finalizer' in self._testMethodName):
-    #             self.tracked_connections.append(conn)
-            
-    #         return conn
-        
-    #     # Apply the patch to track connections
-    #     self.connect_patcher = patch('databricks.sql.connect', patched_connect)
-    #     self.connect_patcher.start()
-    
-    # def tearDown(self):
-    #     """Clean up connections after each test"""
-    #     # Close all tracked connections
-    #     for conn in self.tracked_connections:
-    #         try:
-    #             if hasattr(conn, 'open') and conn.open:
-    #                 conn.close()
-    #         except Exception as e:
-    #             # Log the error but don't fail the test
-    #             print(f"Warning: Error closing connection in tearDown: {e}")
-        
-    #     # Stop the connect patcher
-    #     self.connect_patcher.stop()
-        
-    #     # Clear the tracked connections list
-    #     self.tracked_connections.clear()
-
     @patch("%s.client.ThriftBackend" % PACKAGE_NAME)
     def test_close_uses_the_correct_session_id(self, mock_client_class):
         instance = mock_client_class.return_value
@@ -790,7 +752,6 @@ def test_access_current_query_id(self):
 
         cursor.close()
         self.assertIsNone(cursor.query_id)
-        connection.close()
 
     def test_cursor_close_handles_exception(self):
         """Test that Cursor.close() handles exceptions from close_command properly."""