Skip to content

Commit 1d515e3

Browse files
rename transformation functions to normalise for metadata cols
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
1 parent 2b1442f commit 1d515e3

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/databricks/sql/backend/sea/result_set.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ def fetchmany_json(self, size: int) -> List[List[str]]:
165165
raise ValueError(f"size argument for fetchmany is {size} but must be >= 0")
166166

167167
results = self.results.next_n_rows(size)
168-
results = self._transform_json_rows(results)
168+
results = self._normalise_json_metadata_cols(results)
169169
self._next_row_index += len(results)
170170

171171
return results
@@ -179,7 +179,7 @@ def fetchall_json(self) -> List[List[str]]:
179179
"""
180180

181181
results = self.results.remaining_rows()
182-
results = self._transform_json_rows(results)
182+
results = self._normalise_json_metadata_cols(results)
183183
self._next_row_index += len(results)
184184

185185
return results
@@ -205,11 +205,11 @@ def fetchmany_arrow(self, size: int) -> "pyarrow.Table":
205205
results = self.results.next_n_rows(size)
206206
if isinstance(self.results, JsonQueue):
207207
# Transform JSON first, then convert to Arrow
208-
transformed_json = self._transform_json_rows(results)
208+
transformed_json = self._normalise_json_metadata_cols(results)
209209
results = self._convert_json_to_arrow_table(transformed_json)
210210
else:
211211
# Transform Arrow table directly
212-
results = self._transform_arrow_table(results)
212+
results = self._normalise_arrow_metadata_cols(results)
213213

214214
self._next_row_index += results.num_rows
215215

@@ -223,11 +223,11 @@ def fetchall_arrow(self) -> "pyarrow.Table":
223223
results = self.results.remaining_rows()
224224
if isinstance(self.results, JsonQueue):
225225
# Transform JSON first, then convert to Arrow
226-
transformed_json = self._transform_json_rows(results)
226+
transformed_json = self._normalise_json_metadata_cols(results)
227227
results = self._convert_json_to_arrow_table(transformed_json)
228228
else:
229229
# Transform Arrow table directly
230-
results = self._transform_arrow_table(results)
230+
results = self._normalise_arrow_metadata_cols(results)
231231

232232
self._next_row_index += results.num_rows
233233

@@ -348,7 +348,7 @@ def _prepare_column_mapping(self) -> None:
348348

349349
self.description = new_description
350350

351-
def _transform_arrow_table(self, table: "pyarrow.Table") -> "pyarrow.Table":
351+
def _normalise_arrow_metadata_cols(self, table: "pyarrow.Table") -> "pyarrow.Table":
352352
"""Transform arrow table columns for metadata normalization."""
353353
if not self._metadata_columns:
354354
return table
@@ -384,7 +384,7 @@ def _transform_arrow_table(self, table: "pyarrow.Table") -> "pyarrow.Table":
384384

385385
return pyarrow.Table.from_arrays(new_columns, names=column_names)
386386

387-
def _transform_json_rows(self, rows: List[List[str]]) -> List[List[Any]]:
387+
def _normalise_json_metadata_cols(self, rows: List[List[str]]) -> List[List[Any]]:
388388
"""Transform JSON rows for metadata normalization."""
389389
if not self._metadata_columns:
390390
return rows

0 commit comments

Comments
 (0)