Skip to content

Commit 2dd0f9a

Browse files
benfleissusodapop
authored andcommitted
reorg dust tests + pysql rename
- rename all build/test pyhive/cmdexec symbols to pysql_v1 and pysql_v2. - rename DBSQL -> PySQL - drop exclude gRPC flag
1 parent fd2602c commit 2dd0f9a

File tree

6 files changed

+14
-8
lines changed

6 files changed

+14
-8
lines changed

cmdexec/clients/python/dev_requirements.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,5 @@ protobuf==3.18.1
44
cryptography==35.0.0
55
thrift==0.13.0
66
pandas==1.3.4
7-
future==0.18.2
7+
future==0.18.2
8+
packaging==21.3

cmdexec/clients/python/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
version="2.0.0-rc1",
66
package_dir={"": "src"},
77
packages=setuptools.find_packages(where="src"),
8-
install_requires=["pyarrow", 'thrift>=0.10.0', "pandas"],
8+
install_requires=["pyarrow", 'thrift>=0.13.0', "pandas"],
99
author="Databricks",
1010
)
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
#!/bin/bash
2+
3+
set -e
4+
5+
docker run $(./cmdexec/clients/pysql_v2-test-container-full_binary_loader) unit
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Thrift-dbr-test-classes
22

33
The classes defined in this folder depend on base classes defined in runtime.
4-
(sql/hive-thriftserver/pythontesting/) They are to be combined in the test-docker-image, see e.g. //cmdexec/client/dbsql-test-image.
4+
(sql/hive-thriftserver/pythontesting/) They are to be combined in the test-docker-image, see e.g. //cmdexec/client/pysql\_v2-test-image.
55

6-
These test suites are used for running existing tests that were originally created for ODBC on the python clients that live in universe.
6+
These test suites are used for running existing tests that were originally created for ODBC on the python clients that live in universe.

cmdexec/clients/python/thrift_dbr_test/thrift_basic_tests.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55

66

77
# Base classes are defined in runtime:sql/hive-thriftserver/pythontesting/
8-
# They are to be combined in the test-docker-image (//cmdexec/client/dbsql-test-image)
9-
class DBSQLBasicSuite(PyHiveThriftTestCase, SparkBasicSuiteBase):
8+
# They are to be combined in the test-docker-image (//cmdexec/client/pysql-test-image)
9+
class PySQLBasicSuite(PyHiveThriftTestCase, SparkBasicSuiteBase):
1010
error_type = databricks.sql.Error
1111

1212

cmdexec/clients/python/thrift_dbr_test/thrift_sqlquery_tests.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55

66

77
# Base classes are defined in runtime:sql/hive-thriftserver/pythontesting/
8-
# They are to be combined in the test-docker-image (//cmdexec/client/dbsql-test-image)
9-
class DBSQLSQLQueryTestSuite(PyHiveThriftTestCase, SQLQueryTestSuite):
8+
# They are to be combined in the test-docker-image (//cmdexec/client/pysql_v2-test-image)
9+
class PySQLQueryTestSuite(PyHiveThriftTestCase, SQLQueryTestSuite):
1010
error_type = databricks.sql.Error
1111
# 1 (\S+): exception type
1212
# 2 (.+?): exception message

0 commit comments

Comments
 (0)