Skip to content

Commit 4e07f02

Browse files
varun-edachali-dbxsaishreeeee
authored andcommitted
fix type issues
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
1 parent e84ba7d commit 4e07f02

File tree

3 files changed

+14
-7
lines changed

3 files changed

+14
-7
lines changed

src/databricks/sql/backend/databricks_client.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ def execute_command(
101101
parameters: List of parameters to bind to the query
102102
async_op: Whether to execute the command asynchronously
103103
enforce_embedded_schema_correctness: Whether to enforce schema correctness
104+
row_limit: Maximum number of rows in the response.
104105
105106
Returns:
106107
If async_op is False, returns a ResultSet object containing the

src/databricks/sql/backend/sea/backend.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
MetadataCommands,
1616
)
1717
from databricks.sql.thrift_api.TCLIService import ttypes
18+
from databricks.sql.thrift_api.TCLIService import ttypes
1819

1920
if TYPE_CHECKING:
2021
from databricks.sql.client import Cursor
@@ -403,7 +404,7 @@ def execute_command(
403404
lz4_compression: bool,
404405
cursor: Cursor,
405406
use_cloud_fetch: bool,
406-
parameters: Union[List[Dict[str, Any]], List["ttypes.TSparkParameter"]],
407+
parameters: List[ttypes.TSparkParameter],
407408
async_op: bool,
408409
enforce_embedded_schema_correctness: bool,
409410
row_limit: Optional[int] = None,
@@ -438,9 +439,11 @@ def execute_command(
438439
for param in parameters:
439440
sea_parameters.append(
440441
StatementParameter(
441-
name=param["name"],
442-
value=param["value"],
443-
type=param["type"] if "type" in param else None,
442+
name=param.name,
443+
value=(
444+
param.value.stringValue if param.value is not None else None
445+
),
446+
type=param.type,
444447
)
445448
)
446449

tests/unit/test_sea_backend.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
_filter_session_configuration,
1414
)
1515
from databricks.sql.backend.types import SessionId, CommandId, CommandState, BackendType
16+
from databricks.sql.parameters.native import IntegerParameter, TDbsqlParameter
17+
from databricks.sql.thrift_api.TCLIService import ttypes
1618
from databricks.sql.types import SSLOptions
1719
from databricks.sql.auth.authenticators import AuthProvider
1820
from databricks.sql.exc import (
@@ -355,7 +357,8 @@ def test_command_execution_advanced(
355357
"status": {"state": "SUCCEEDED"},
356358
}
357359
mock_http_client._make_request.return_value = execute_response
358-
param = {"name": "param1", "value": "value1", "type": "STRING"}
360+
dbsql_param = IntegerParameter(name="param1", value=1)
361+
param = dbsql_param.as_tspark_param(named=True)
359362

360363
with patch.object(sea_client, "get_execution_result"):
361364
sea_client.execute_command(
@@ -374,8 +377,8 @@ def test_command_execution_advanced(
374377
assert "parameters" in kwargs["data"]
375378
assert len(kwargs["data"]["parameters"]) == 1
376379
assert kwargs["data"]["parameters"][0]["name"] == "param1"
377-
assert kwargs["data"]["parameters"][0]["value"] == "value1"
378-
assert kwargs["data"]["parameters"][0]["type"] == "STRING"
380+
assert kwargs["data"]["parameters"][0]["value"] == "1"
381+
assert kwargs["data"]["parameters"][0]["type"] == "INT"
379382

380383
# Test execution failure
381384
mock_http_client.reset_mock()

0 commit comments

Comments
 (0)