Skip to content

Commit 6e1b4d3

Browse files
raise error for invalid data
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
1 parent 6862929 commit 6e1b4d3

File tree

3 files changed

+6
-16
lines changed

3 files changed

+6
-16
lines changed

src/databricks/sql/backend/utils/http_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def _make_request(
145145
if response.content:
146146
result = response.json()
147147
# Log response content (but limit it for large responses)
148-
content_str = json.dumps(result)
148+
content_str = json.dumps(result, indent=2, sort_keys=True)
149149
if len(content_str) > 1000:
150150
logger.debug(
151151
f"Response content (truncated): {content_str[:1000]}..."

src/databricks/sql/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ def build_queue(
143143
raise NotImplementedError("EXTERNAL_LINKS disposition is not supported yet")
144144
else:
145145
# Empty result set
146-
return JsonQueue([])
146+
raise AssertionError("Result data is not valid")
147147

148148

149149
class JsonQueue(ResultSetQueue):

tests/unit/test_result_set_queue_factories.py

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,8 @@ def test_sea_result_set_queue_factory_with_empty_data(self):
5252
result_data.data = []
5353
result_data.external_links = None
5454

55-
# Build queue
56-
queue = SeaResultSetQueueFactory.build_queue(result_data)
57-
58-
# Verify queue type
59-
self.assertIsInstance(queue, JsonQueue)
60-
self.assertEqual(queue.n_valid_rows, 0)
61-
self.assertEqual(queue.data_array, [])
55+
with self.assertRaises(AssertionError):
56+
SeaResultSetQueueFactory.build_queue(result_data)
6257

6358
def test_sea_result_set_queue_factory_with_external_links(self):
6459
"""Test SeaResultSetQueueFactory with external links."""
@@ -78,13 +73,8 @@ def test_sea_result_set_queue_factory_with_no_data(self):
7873
result_data.data = None
7974
result_data.external_links = None
8075

81-
# Build queue
82-
queue = SeaResultSetQueueFactory.build_queue(result_data)
83-
84-
# Verify queue type
85-
self.assertIsInstance(queue, JsonQueue)
86-
self.assertEqual(queue.n_valid_rows, 0)
87-
self.assertEqual(queue.data_array, [])
76+
with self.assertRaises(AssertionError):
77+
SeaResultSetQueueFactory.build_queue(result_data)
8878

8979

9080
if __name__ == "__main__":

0 commit comments

Comments
 (0)