Skip to content

Commit 8afc5d5

Browse files
command_handle -> command_id in ExecuteResponse
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
1 parent b295acd commit 8afc5d5

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

tests/unit/test_client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def new(cls):
4242
mock_result_set,
4343
description=None,
4444
is_staging_operation=False,
45-
command_handle=b"\x22",
45+
command_id=None,
4646
has_been_closed_server_side=True,
4747
has_more_rows=True,
4848
lz4_compressed=True,
@@ -159,7 +159,7 @@ def test_closing_result_set_hard_closes_commands(self):
159159
result_set.close()
160160

161161
mock_thrift_backend.close_command.assert_called_once_with(
162-
mock_results_response.command_handle
162+
mock_results_response.command_id
163163
)
164164

165165
@patch("%s.result_set.ThriftResultSet" % PACKAGE_NAME)

tests/unit/test_fetches.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def make_dummy_result_set_from_initial_results(initial_results):
4747
has_more_rows=False,
4848
description=Mock(),
4949
lz4_compressed=Mock(),
50-
command_handle=None,
50+
command_id=None,
5151
arrow_queue=arrow_queue,
5252
arrow_schema_bytes=schema.serialize().to_pybytes(),
5353
is_staging_operation=False,
@@ -96,7 +96,7 @@ def fetch_results(
9696
for col_id in range(num_cols)
9797
],
9898
lz4_compressed=Mock(),
99-
command_handle=None,
99+
command_id=None,
100100
arrow_queue=None,
101101
arrow_schema_bytes=None,
102102
is_staging_operation=False,

tests/unit/test_fetches_bench.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def make_dummy_result_set_from_initial_results(arrow_table):
3737
has_been_closed_server_side=True,
3838
has_more_rows=False,
3939
description=Mock(),
40-
command_handle=None,
40+
command_id=None,
4141
arrow_queue=arrow_queue,
4242
arrow_schema=arrow_table.schema,
4343
),

0 commit comments

Comments
 (0)