Skip to content

Commit b3f6fb0

Browse files
Ubuntususodapop
authored andcommitted
Split and move proto defintions
Splits the proto service definition in a version with only unary rpcs `sql_command_service.proto` and `sql_command_service_experimental.proto` in which we can continue development/experiments/tests with streaming rpcs. `sql_command_service.proto` is a strict subset of `sql_command_service_experimental.proto` and the intersection of the commands are compatible with each other. In places where we are not restricted to old ScalaPB, we can use `sql_command_service_experimental.proto`. The request/response types have been moved to a separate file `messages.proto` that both service files import (to aid in keeping them compatible and reduce duplication). I've also created top-level types for the responses, instead of nesting them in the request types, as this is not standard practice for gRPC. Finally, this moves the protos to the top-level cmdexec folder. Regular tests / manual test with local server and `CLITestClient` / python client unit tests Author: Sander Goos <sander.goos@databricks.com>
1 parent cbf45b6 commit b3f6fb0

File tree

6 files changed

+643
-726
lines changed

6 files changed

+643
-726
lines changed

cmdexec/clients/python/sql_command_service_pb2.py renamed to cmdexec/clients/python/api/messages_pb2.py

Lines changed: 436 additions & 611 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# Generated by the gRPC Python protocol compiler plugin. DO NOT EDIT!
2+
"""Client and server classes corresponding to protobuf-defined services."""
3+
import grpc

cmdexec/clients/python/api/sql_cmd_service_pb2.py

Lines changed: 116 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)