use lazy logging

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>

Author: varun-edachali-dbx

src/databricks/sql/backend/thrift_backend.py

@@ -1229,7 +1229,7 @@ def cancel_command(self, command_id: CommandId) -> None:
         if not thrift_handle:
             raise ValueError("Not a valid Thrift command ID")
 
-        logger.debug("Cancelling command {}".format(command_id.to_hex_guid()))
+        logger.debug("Cancelling command %s", command_id.to_hex_guid())
         req = ttypes.TCancelOperationReq(thrift_handle)
         self.make_request(self._client.CancelOperation, req)
 

src/databricks/sql/backend/utils/guid_utils.py

@@ -18,6 +18,6 @@ def guid_to_hex_id(guid: bytes) -> str:
     try:
         this_uuid = uuid.UUID(bytes=guid)
     except Exception as e:
-        logger.debug(f"Unable to convert bytes to UUID: {guid!r} -- {str(e)}")
+        logger.debug("Unable to convert bytes to UUID: %r -- %s", guid, str(e))
         return str(guid)
     return str(this_uuid)

src/databricks/sql/session.py

@@ -95,7 +95,7 @@ def open(self):
         )
         self.protocol_version = self.get_protocol_version(self._session_id)
         self.is_open = True
-        logger.info("Successfully opened session " + str(self.get_id_hex()))
+        logger.info("Successfully opened session %s", str(self.get_id_hex()))
 
     @staticmethod
     def get_protocol_version(session_id: SessionId):
@@ -125,7 +125,7 @@ def get_id_hex(self) -> str:
 
     def close(self) -> None:
         """Close the underlying session."""
-        logger.info(f"Closing session {self.get_id_hex()}")
+        logger.info("Closing session %s", self.get_id_hex())
         if not self.is_open:
             logger.debug("Session appears to have been closed already")
             return
@@ -138,13 +138,13 @@ def close(self) -> None:
         except DatabaseError as e:
             if "Invalid SessionHandle" in str(e):
                 logger.warning(
-                    f"Attempted to close session that was already closed: {e}"
+                    "Attempted to close session that was already closed: %s", e
                 )
             else:
                 logger.warning(
-                    f"Attempt to close session raised an exception at the server: {e}"
+                    "Attempt to close session raised an exception at the server: %s", e
                 )
         except Exception as e:
-            logger.error(f"Attempt to close session raised a local exception: {e}")
+            logger.error("Attempt to close session raised a local exception: %s", e)
 
         self.is_open = False