remove unimplemented metadata methods test, un-necessary imports

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>

Author: varun-edachali-dbx

src/databricks/sql/backend/sea/backend.py

@@ -41,9 +41,9 @@
     CreateSessionResponse,
 )
 from databricks.sql.backend.sea.models.responses import (
-    parse_status,
-    parse_manifest,
-    parse_result,
+    _parse_status,
+    _parse_manifest,
+    _parse_result,
 )
 
 logger = logging.getLogger(__name__)

src/databricks/sql/backend/sea/models/responses.py

@@ -18,7 +18,7 @@
 )
 
 
-def parse_status(data: Dict[str, Any]) -> StatementStatus:
+def _parse_status(data: Dict[str, Any]) -> StatementStatus:
     """Parse status from response data."""
     status_data = data.get("status", {})
     error = None
@@ -40,7 +40,7 @@ def parse_status(data: Dict[str, Any]) -> StatementStatus:
     )
 
 
-def parse_manifest(data: Dict[str, Any]) -> ResultManifest:
+def _parse_manifest(data: Dict[str, Any]) -> ResultManifest:
     """Parse manifest from response data."""
 
     manifest_data = data.get("manifest", {})
@@ -69,7 +69,7 @@ def parse_manifest(data: Dict[str, Any]) -> ResultManifest:
     )
 
 
-def parse_result(data: Dict[str, Any]) -> ResultData:
+def _parse_result(data: Dict[str, Any]) -> ResultData:
     """Parse result data from response data."""
     result_data = data.get("result", {})
     external_links = None
@@ -118,9 +118,9 @@ def from_dict(cls, data: Dict[str, Any]) -> "ExecuteStatementResponse":
         """Create an ExecuteStatementResponse from a dictionary."""
         return cls(
             statement_id=data.get("statement_id", ""),
-            status=parse_status(data),
-            manifest=parse_manifest(data),
-            result=parse_result(data),
+            status=_parse_status(data),
+            manifest=_parse_manifest(data),
+            result=_parse_result(data),
         )
 
 
@@ -138,9 +138,9 @@ def from_dict(cls, data: Dict[str, Any]) -> "GetStatementResponse":
         """Create a GetStatementResponse from a dictionary."""
         return cls(
             statement_id=data.get("statement_id", ""),
-            status=parse_status(data),
-            manifest=parse_manifest(data),
-            result=parse_result(data),
+            status=_parse_status(data),
+            manifest=_parse_manifest(data),
+            result=_parse_result(data),
         )
 
 

tests/unit/test_filters.py

@@ -4,11 +4,6 @@
 
 import unittest
 from unittest.mock import MagicMock, patch
-import sys
-from typing import List, Dict, Any
-
-# Add the necessary path to import the filter module
-sys.path.append("/home/varun.edachali/conn/databricks-sql-python/src")
 
 from databricks.sql.backend.filters import ResultSetFilter
 

tests/unit/test_sea_backend.py

@@ -631,55 +631,4 @@ def test_utility_methods(self, sea_client):
         assert (
             sea_client._extract_description_from_manifest(no_columns_manifest) is None
         )
-
-    def test_unimplemented_metadata_methods(
-        self, sea_client, sea_session_id, mock_cursor
-    ):
-        """Test that metadata methods raise NotImplementedError."""
-        # Test get_catalogs
-        with pytest.raises(NotImplementedError):
-            sea_client.get_catalogs(sea_session_id, 100, 1000, mock_cursor)
-
-        # Test get_schemas
-        with pytest.raises(NotImplementedError):
-            sea_client.get_schemas(sea_session_id, 100, 1000, mock_cursor)
-
-        # Test get_schemas with optional parameters
-        with pytest.raises(NotImplementedError):
-            sea_client.get_schemas(
-                sea_session_id, 100, 1000, mock_cursor, "catalog", "schema"
-            )
-
-        # Test get_tables
-        with pytest.raises(NotImplementedError):
-            sea_client.get_tables(sea_session_id, 100, 1000, mock_cursor)
-
-        # Test get_tables with optional parameters
-        with pytest.raises(NotImplementedError):
-            sea_client.get_tables(
-                sea_session_id,
-                100,
-                1000,
-                mock_cursor,
-                catalog_name="catalog",
-                schema_name="schema",
-                table_name="table",
-                table_types=["TABLE", "VIEW"],
-            )
-
-        # Test get_columns
-        with pytest.raises(NotImplementedError):
-            sea_client.get_columns(sea_session_id, 100, 1000, mock_cursor)
-
-        # Test get_columns with optional parameters
-        with pytest.raises(NotImplementedError):
-            sea_client.get_columns(
-                sea_session_id,
-                100,
-                1000,
-                mock_cursor,
-                catalog_name="catalog",
-                schema_name="schema",
-                table_name="table",
-                column_name="column",
-            )
+