From 5e007d61bb6f64717dd1d374cecbe203cfc969e0 Mon Sep 17 00:00:00 2001 From: Stefan Berger Date: Mon, 29 Dec 2025 18:51:48 +0100 Subject: [PATCH 1/2] Fix detailed error codes on Windows Switches from Powershell to cmd since Powershell hides the original exit code. --- plugin.yaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/plugin.yaml b/plugin.yaml index 7512bc2f..433da151 100644 --- a/plugin.yaml +++ b/plugin.yaml @@ -7,11 +7,13 @@ description: "Preview helm upgrade changes as a diff" useTunnel: true platformCommand: - command: ${HELM_PLUGIN_DIR}/bin/diff + # powershell does not return the original exit code, while cmd does + # see https://github.com/databus23/helm-diff/issues/910 - os: windows - command: pwsh + command: cmd args: - - -Command - - "& (Join-Path -Path (Get-ChildItem env:HELM_PLUGIN_DIR).value -ChildPath 'bin\\diff')" + - /c + - "%HELM_PLUGIN_DIR%/bin/diff" platformHooks: install: From fe61451c9f338b837688535df77cfe0f7064adeb Mon Sep 17 00:00:00 2001 From: Stefan Berger Date: Mon, 29 Dec 2025 19:05:35 +0100 Subject: [PATCH 2/2] Call diff.exe directly on Windows --- plugin.yaml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/plugin.yaml b/plugin.yaml index 433da151..ecb84263 100644 --- a/plugin.yaml +++ b/plugin.yaml @@ -7,13 +7,6 @@ description: "Preview helm upgrade changes as a diff" useTunnel: true platformCommand: - command: ${HELM_PLUGIN_DIR}/bin/diff - # powershell does not return the original exit code, while cmd does - # see https://github.com/databus23/helm-diff/issues/910 - - os: windows - command: cmd - args: - - /c - - "%HELM_PLUGIN_DIR%/bin/diff" platformHooks: install: