Skip to content

Commit 00be618

Browse files
Apply suggestions from code review
Co-authored-by: nicolasservel <nico.servel@gmail.com>
1 parent 0e44fee commit 00be618

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

dataikuapi/dss/ml.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -914,7 +914,7 @@ class PredictionAlgorithmSettings(dict):
914914
"""
915915
Object to read and modify the settings of a prediction ML algorithm.
916916
917-
Do not create this object directly, use :meth:`DSSMLTask.get_algorithm_settings(algorithm)` instead
917+
Do not create this object directly, use :meth:`DSSMLTask.get_algorithm_settings` instead
918918
"""
919919

920920
def __init__(self, raw_settings, hyperparameter_search_params):
@@ -1046,7 +1046,7 @@ class GradientBoostedTreesSettings(PredictionAlgorithmSettings):
10461046

10471047
def __init__(self, raw_settings, hyperparameter_search_params):
10481048
super(GradientBoostedTreesSettings, self).__init__(raw_settings, hyperparameter_search_params)
1049-
self.n_estimators = self._register_numerical_hyperparameter("n_estimator")
1049+
self.n_estimators = self._register_numerical_hyperparameter("n_estimators")
10501050
self.max_depth = self._register_numerical_hyperparameter("max_depth")
10511051
self.min_samples_leaf = self._register_numerical_hyperparameter("min_samples_leaf")
10521052
self.max_features = self._register_numerical_hyperparameter("max_features")
@@ -1080,7 +1080,7 @@ class RidgeRegressionSettings(PredictionAlgorithmSettings):
10801080

10811081
def __init__(self, raw_settings, hyperparameter_search_params):
10821082
super(RidgeRegressionSettings, self).__init__(raw_settings, hyperparameter_search_params)
1083-
self.alpha = self._register_numerical_hyperparameter("alpha", self)
1083+
self.alpha = self._register_numerical_hyperparameter("alpha")
10841084
self.alpha_mode = self._register_single_category_hyperparameter("alphaMode", accepted_values=["MANUAL", "AUTO"])
10851085

10861086

@@ -1308,7 +1308,7 @@ def get_algorithm_settings(self, algorithm_name):
13081308
Gets the training settings for a particular algorithm. This returns a reference to the
13091309
algorithm's settings, not a copy, so changes made to the returned object will be reflected when saving.
13101310
1311-
This method returns the settings for this algorithm as an AlgorithmSettings (extended dict).
1311+
This method returns the settings for this algorithm as an PredictionAlgorithmSettings (extended dict).
13121312
All algorithm dicts have at least an "enabled" property/key in the settings.
13131313
The "enabled" property/key indicates whether this algorithm will be trained.
13141314

0 commit comments

Comments
 (0)