Make make_zipfile 'private' (#183)

Author: Valentin Thorey

dataikuapi/dss/savedmodel.py

@@ -5,7 +5,7 @@
 from .ml import DSSTrainedClusteringModelDetails
 from .ml import DSSTrainedPredictionModelDetails
 
-from ..utils import make_zipfile
+from ..utils import _make_zipfile
 
 try:
     basestring
@@ -141,7 +141,7 @@ def import_mlflow_version_from_path(self, version_id, path, code_env_name="INHER
 
         archive_temp_dir = tempfile.mkdtemp()
         try:
-            archive_filename = make_zipfile(os.path.join(archive_temp_dir, "tmpmodel.zip"), path)
+            archive_filename = _make_zipfile(os.path.join(archive_temp_dir, "tmpmodel.zip"), path)
 
             with open(archive_filename, "rb") as fp:
                 self.client._perform_empty("POST", "/projects/%s/savedmodels/%s/versions/%s?codeEnvName=%s" % (self.project_key, self.sm_id, version_id, code_env_name),

dataikuapi/utils.py

@@ -104,10 +104,7 @@ def __call__(self):
         return self.val
 
 
-def make_zipfile(output_filename, source_dir):
-    """Replace shutil.make_archive which adds undesired folders to the archive
-    in python 2.7 in some environments.
-    """
+def _make_zipfile(output_filename, source_dir):
     relroot = os.path.abspath(os.path.join(source_dir))
     with zipfile.ZipFile(output_filename, "w", zipfile.ZIP_DEFLATED) as zipfp:
         for root, dirs, files in os.walk(source_dir):