Fix loop variable overwriting method argument causing the wrong feature to be set as sample weight

Author: samronsin

dataikuapi/dss/ml.py

@@ -422,9 +422,9 @@ def set_weighting(self, method, feature_name=None):
         """
 
         # First, if there was a WEIGHT feature, restore it as INPUT
-        for feature_name in self.mltask_settings['preprocessing']['per_feature']:
-            if self.mltask_settings['preprocessing']['per_feature'][feature_name]['role'] == 'WEIGHT':
-                 self.mltask_settings['preprocessing']['per_feature'][feature_name]['role'] = 'INPUT'
+        for other_feature_name in self.mltask_settings['preprocessing']['per_feature']:
+            if self.mltask_settings['preprocessing']['per_feature'][other_feature_name]['role'] == 'WEIGHT':
+                self.mltask_settings['preprocessing']['per_feature'][other_feature_name]['role'] = 'INPUT'
 
         if method == "NO_WEIGHTING":
             self.mltask_settings['weight']['weightMethod'] = method