Skip to content

Commit b650867

Browse files
committed
Fix creation of FSlike datasets like S3
1 parent e2b6e41 commit b650867

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

dataikuapi/dss/tools/codegen.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,14 @@ def _generate_code_for_dataset(self, dataset, entrypoint_name):
9393
do_not_copy.append("params")
9494

9595
elif raw["type"] in DSSDataset.FS_TYPES:
96-
self.gen(" dataset = project.create_dataset(\"%s\", \"%s\")" % (dataset.dataset_name, raw["type"]))
96+
srcp = raw["params"]
97+
self.gen(" dataset = project.create_fslike_dataset(\"%s\", \"%s\", \"%s\", \"%s\")" % \
98+
(dataset.dataset_name, raw["type"], srcp["connection"], srcp.get("path", "/")))
9799
self.gen(" settings = dataset.get_settings()")
98100
self.lf()
99101

100-
srcp = raw["params"]
101-
self.gen(" settings.set_connection_and_path(%s, %s)" % \
102-
(self.objstr(srcp.get("connection")), self.objstr(srcp.get("path"))))
102+
#self.gen(" settings.set_connection_and_path(%s, %s)" % \
103+
# (self.objstr(srcp.get("connection")), self.objstr(srcp.get("path"))))
103104
self.codegen_object_fields(srcp, templates["abstractFSConfig"],
104105
["connection", "path"], "settings.get_raw_params()")
105106
do_not_copy.append("params")
@@ -327,10 +328,9 @@ def codegen_object_field(self, object, key, template, prefix):
327328
#print("Skipping value equal to default: %s" % key)
328329
return
329330
else:
330-
if key == "engineParams":
331-
print("Not equal for %s" % key)
332-
print("Template: %s" % default_value_for_key)
333-
print("Real: %s" % value_for_key)
331+
#print("Not equal for %s" % key)
332+
#print("Template: %s" % default_value_for_key)
333+
#print("Real: %s" % value_for_key)
334334
self.gen(" %s[\"%s\"] = %s" % ( prefix, key, self.objstr(value_for_key)))
335335

336336

0 commit comments

Comments
 (0)