Skip to content

Commit cc12875

Browse files
author
Agathe Guillemot
committed
Nitpicks
Do not break during for loop + use get in remove_node method Remove return on delete call
1 parent d4e540a commit cc12875

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

dataikuapi/dss/apideployer.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def delete(self):
171171
Deletes this infra
172172
You may only delete an infra if it has no deployments on it anymore.
173173
"""
174-
return self.client._perform_empty(
174+
self.client._perform_empty(
175175
"DELETE", "/api-deployer/infras/%s" % (self.infra_id))
176176

177177

@@ -207,10 +207,10 @@ def remove_apinode(self, node_url):
207207
208208
:param str node_url: URL of the node to remove
209209
"""
210-
for node in self.settings["apiNodes"]:
211-
if node["url"] == node_url:
210+
api_nodes = list(self.settings["apiNodes"])
211+
for node in api_nodes:
212+
if node.get("url") == node_url:
212213
self.settings["apiNodes"].remove(node)
213-
break
214214

215215
def get_raw(self):
216216
"""

0 commit comments

Comments
 (0)