Skip to content

Commit e240760

Browse files
authored
Support DSSDataset or dataiku.Dataset in MLFlowVersionHandler.evaluate (#189)
* Support DSSDataset or dataiku.Dataset in MLFlowVersionHandler.evaluate * Adjust a comment
1 parent c948318 commit e240760

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

dataikuapi/dss/savedmodel.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -315,9 +315,10 @@ def evaluate(self, dataset_ref):
315315
316316
:meth:`set_core_metadata` must be called before you can evaluate a dataset
317317
318-
:param str dataset_ref: Name of the evaluation dataset to use (either a dataset name or "PROJECT.datasetName")
318+
:param str dataset_ref: Evaluation dataset to use (either a dataset name, "PROJECT.datasetName", DSSDataset instance or dataiku.Dataset instance)
319319
"""
320-
# TODO Add support for handling a DSSDataset or dataiku.Dataset as dataset_ref
320+
if hasattr(dataset_ref, 'name'):
321+
dataset_ref = dataset_ref.name
321322
req = {
322323
"datasetRef" : dataset_ref
323324
}
@@ -348,4 +349,4 @@ def prediction_metrics_settings(self):
348349
def save(self):
349350
"""Saves the settings of this saved model"""
350351
self.saved_model.client._perform_empty("PUT", "/projects/%s/savedmodels/%s" % (self.saved_model.project_key, self.saved_model.sm_id),
351-
body=self.settings)
352+
body=self.settings)

0 commit comments

Comments
 (0)