fix: Add column name aliases for all MySQL information_schema queries

Extended the column name alias fix to get_indexes_sql() and updated
tests that call declare() directly to pass the adapter parameter.

Fixes:
- get_indexes_sql() now uses uppercase column names with lowercase aliases
- get_foreign_keys_sql() already fixed in previous commit
- test_declare.py: Updated 3 tests to pass adapter and compare SQL only
- test_json.py: Updated test_describe to pass adapter and compare SQL only

Note: test_describe tests now reveal a pre-existing bug where describe()
doesn't preserve NOT NULL constraints for foreign key attributes. This is
unrelated to the adapter changes.

Related: #1338

Author: dimitri-yatsenko

src/datajoint/adapters/mysql.py

@@ -637,7 +637,7 @@ def parse_foreign_key_error(self, error_message: str) -> dict[str, str | list[st
     def get_indexes_sql(self, schema_name: str, table_name: str) -> str:
         """Query to get index definitions."""
         return (
-            f"SELECT index_name, column_name, non_unique "
+            f"SELECT INDEX_NAME as index_name, COLUMN_NAME as column_name, NON_UNIQUE as non_unique "
             f"FROM information_schema.statistics "
             f"WHERE table_schema = {self.quote_string(schema_name)} "
             f"AND table_name = {self.quote_string(table_name)} "

tests/integration/test_declare.py

@@ -44,27 +44,30 @@ def test_describe(schema_any):
     """real_definition should match original definition"""
     rel = Experiment()
     context = inspect.currentframe().f_globals
-    s1 = declare(rel.full_table_name, rel.definition, context)
-    s2 = declare(rel.full_table_name, rel.describe(), context)
-    assert s1 == s2
+    adapter = rel.connection.adapter
+    s1 = declare(rel.full_table_name, rel.definition, context, adapter)
+    s2 = declare(rel.full_table_name, rel.describe(), context, adapter)
+    assert s1[0] == s2[0]  # Compare SQL only (declare now returns tuple)
 
 
 def test_describe_indexes(schema_any):
     """real_definition should match original definition"""
     rel = IndexRich()
     context = inspect.currentframe().f_globals
-    s1 = declare(rel.full_table_name, rel.definition, context)
-    s2 = declare(rel.full_table_name, rel.describe(), context)
-    assert s1 == s2
+    adapter = rel.connection.adapter
+    s1 = declare(rel.full_table_name, rel.definition, context, adapter)
+    s2 = declare(rel.full_table_name, rel.describe(), context, adapter)
+    assert s1[0] == s2[0]  # Compare SQL only (declare now returns tuple)
 
 
 def test_describe_dependencies(schema_any):
     """real_definition should match original definition"""
     rel = ThingC()
     context = inspect.currentframe().f_globals
-    s1 = declare(rel.full_table_name, rel.definition, context)
-    s2 = declare(rel.full_table_name, rel.describe(), context)
-    assert s1 == s2
+    adapter = rel.connection.adapter
+    s1 = declare(rel.full_table_name, rel.definition, context, adapter)
+    s2 = declare(rel.full_table_name, rel.describe(), context, adapter)
+    assert s1[0] == s2[0]  # Compare SQL only (declare now returns tuple)
 
 
 def test_part(schema_any):

tests/integration/test_json.py

@@ -122,9 +122,10 @@ def test_insert_update(schema_json):
 def test_describe(schema_json):
     rel = Team()
     context = inspect.currentframe().f_globals
-    s1 = declare(rel.full_table_name, rel.definition, context)
-    s2 = declare(rel.full_table_name, rel.describe(), context)
-    assert s1 == s2
+    adapter = rel.connection.adapter
+    s1 = declare(rel.full_table_name, rel.definition, context, adapter)
+    s2 = declare(rel.full_table_name, rel.describe(), context, adapter)
+    assert s1[0] == s2[0]  # Compare SQL only (declare now returns tuple)
 
 
 def test_restrict(schema_json):