Commit 9ff1eb5
committed
fix: Track connection closed state internally
The is_connected property was relying on ping() to determine if a connection
was closed, but MySQLdb's ping() may succeed even after close() is called.
Now tracks connection state with _is_closed flag that is:
- Set to True in __init__ (before connect)
- Set to False after successful connect()
- Set to True in close()
- Checked first in is_connected before attempting ping()
Fixes test_connection_context_manager, test_connection_context_manager_exception,
and test_close failures.1 parent ddca0ed commit 9ff1eb5
1 file changed
+8
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
| 180 | + | |
180 | 181 | | |
181 | 182 | | |
182 | 183 | | |
| |||
228 | 229 | | |
229 | 230 | | |
230 | 231 | | |
| 232 | + | |
231 | 233 | | |
232 | 234 | | |
233 | 235 | | |
| |||
255 | 257 | | |
256 | 258 | | |
257 | 259 | | |
258 | | - | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
259 | 263 | | |
260 | 264 | | |
261 | 265 | | |
| |||
329 | 333 | | |
330 | 334 | | |
331 | 335 | | |
| 336 | + | |
| 337 | + | |
332 | 338 | | |
333 | 339 | | |
334 | 340 | | |
| 341 | + | |
335 | 342 | | |
336 | 343 | | |
337 | 344 | | |
| |||
0 commit comments