Skip to content

Commit 88f8148

Browse files
committed
don't test with error server
1 parent 25e3e34 commit 88f8148

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

tests/functional/test_drum_server_failures.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,13 @@ def test_ping_endpoints(self, params, with_error_server, production, docker):
128128

129129
@pytest.mark.parametrize(
130130
"with_error_server, production, docker",
131-
[(False, False, None), (True, False, None), (True, True, DOCKER_PYTHON_SKLEARN)],
131+
[(False, False, None), (True, False, None), (False, False, DOCKER_PYTHON_SKLEARN)],
132132
)
133133
def test_e2e_no_model_artifact(self, params, with_error_server, production, docker):
134134
"""
135+
Note: 12/17/2025 DOCKER_PYTHON_SKLEARN image is going to use gunicorn,
136+
so it doesn't support running with error server or production anymore.
137+
135138
Verify that if an error occurs on DRUM server initialization if no model artifact is found
136139
- if '--with-error-server' is not set, DRUM server process will exit with error
137140
- if '--with-error-server' is set, 'error server' will still be started, and
@@ -152,10 +155,13 @@ def test_e2e_no_model_artifact(self, params, with_error_server, production, dock
152155

153156
@pytest.mark.parametrize(
154157
"with_error_server, production, docker",
155-
[(False, False, None), (True, False, None), (True, True, DOCKER_PYTHON_SKLEARN)],
158+
[(False, False, None), (True, False, None), (False, False, DOCKER_PYTHON_SKLEARN)],
156159
)
157160
def test_e2e_model_loading_fails(self, params, with_error_server, production, docker):
158161
"""
162+
Note: 12/17/2025 DOCKER_PYTHON_SKLEARN image is going to use gunicorn,
163+
so it doesn't support running with error server or production anymore.
164+
159165
Verify that if an error occurs on DRUM server initialization if model cannot load properly
160166
- if '--with-error-server' is not set, drum server process will exit with error
161167
- if '--with-error-server' is set, 'error server' will still be started, and

0 commit comments

Comments
 (0)