Skip to content

Commit ea50f65

Browse files
authored
Merge pull request #107 from datocms/feat/disable-tracking
Disable tracking by default
2 parents 9b5d950 + 44c2757 commit ea50f65

File tree

6 files changed

+158
-8073
lines changed

6 files changed

+158
-8073
lines changed

docs/video-player.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ DatoCMS GraphQL API.
105105
Compared to the `<MuxPlayer />`, **some prop default values are different** on `<VideoPlayer />`
106106

107107
- `disableCookies` is normally true, unless you explicitly set the prop to `false`
108+
- `disableTracking` is normally true, unless you explicitly set it to `false`
108109
- `preload` defaults to `metadata`, for an optimal UX experience together with saved bandwidth
109110
- the video height and width, when available in the `data` props, are used to set `{ aspectRatio: "[width] / [height]"}` for the `<MuxPlayer />`'s `style`
110111

examples/package-lock.json

Lines changed: 83 additions & 59 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/src/QuerySubscriptionExample/index.js

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ import {
33
StructuredText,
44
renderMetaTags,
55
useQuerySubscription,
6-
} from 'react-datocms';
7-
import { Helmet } from 'react-helmet';
8-
import './style.css';
6+
} from "react-datocms";
7+
import { Helmet } from "react-helmet";
8+
import "./style.css";
99

1010
const RESPONSIVE_IMAGE_FRAGMENT = `
1111
aspectRatio
@@ -66,22 +66,22 @@ export default function QuerySubscriptionExample() {
6666
const { status, error, data } = useQuerySubscription({
6767
query,
6868
variables: { first: 4 },
69-
token: 'faeb9172e232a75339242faafb9e56de8c8f13b735f7090964',
69+
token: "faeb9172e232a75339242faafb9e56de8c8f13b735f7090964",
7070
});
7171

7272
const metaTags = data ? [...data.page.seo, ...data.site.favicon] : [];
7373

7474
const statusMessage = {
75-
connecting: 'Connecting to DatoCMS...',
76-
connected: 'Connected to DatoCMS, receiving live updates!',
77-
closed: 'Connection closed',
75+
connecting: "Connecting to DatoCMS...",
76+
connected: "Connected to DatoCMS, receiving live updates!",
77+
closed: "Connection closed",
7878
};
7979

8080
return (
8181
<div className="example" data-title="Full-blown example">
8282
<Helmet>{renderMetaTags(metaTags)}</Helmet>
8383
<div className="status">
84-
{status === 'connected' && <div className="connected-badge" />}
84+
{status === "connected" && <div className="connected-badge" />}
8585
{statusMessage[status]}
8686
</div>
8787
{error && (
@@ -96,10 +96,12 @@ export default function QuerySubscriptionExample() {
9696
<div className="blogPosts">
9797
{data?.blogPosts.map((blogPost) => (
9898
<article key={blogPost.id} className="blogPost">
99-
<Image
100-
className="blogPost-image"
101-
data={blogPost.coverImage.responsiveImage}
102-
/>
99+
{blogPost.coverImage?.responsiveImage && (
100+
<Image
101+
className="blogPost-image"
102+
data={blogPost.coverImage.responsiveImage}
103+
/>
104+
)}
103105
<div className="blogPost-content">
104106
<h6 className="blogPost-title">
105107
<a
@@ -114,10 +116,12 @@ export default function QuerySubscriptionExample() {
114116
<StructuredText data={blogPost.excerpt} />
115117
</div>
116118
<footer className="blogPost-author">
117-
<Image
118-
className="blogPost-author-image"
119-
data={blogPost.author.avatar.responsiveImage}
120-
/>
119+
{blogPost.author?.avatar?.responsiveImage && (
120+
<Image
121+
className="blogPost-author-image"
122+
data={blogPost.author.avatar.responsiveImage}
123+
/>
124+
)}
121125
Written by {blogPost.author.name}
122126
</footer>
123127
</div>

0 commit comments

Comments
 (0)