Merge pull request #25 from sharunkumar/master

fix: typing and tests in strict mode, and fix build failure

Author: davidnguyen11

package.json

@@ -40,17 +40,17 @@
     "@babel/core": "^7.9.0",
     "@babel/preset-env": "^7.9.5",
     "@babel/preset-typescript": "^7.9.0",
-    "@types/jest": "^25.2.1",
-    "babel-jest": "^25.3.0",
-    "chalk": "^4.0.0",
+    "@types/jest": "^29.5.1",
+    "babel-jest": "^29.5.0",
+    "chalk": "^5.2.0",
     "husky": "^4.2.5",
-    "jest": "^25.3.0",
-    "lint-staged": "^10.1.4",
+    "jest": "^29.5.0",
+    "lint-staged": "^13.2.2",
     "prettier": "^2.0.4",
-    "rimraf": "^3.0.2",
-    "ts-jest": "^25.3.1",
-    "ts-node": "^8.8.2",
-    "typescript": "^3.8.3"
+    "rimraf": "^5.0.0",
+    "ts-jest": "^29.1.0",
+    "ts-node": "^10.9.1",
+    "typescript": "^5.0.4"
   },
   "husky": {
     "hooks": {
@@ -66,4 +66,4 @@
   "engines": {
     "node": ">=8.0.0"
   }
-}
+}

src/index.ts

@@ -31,7 +31,7 @@ import { IPriorityQueue } from '../typings/priority-queue';
  */
 export class PriorityQueue<T> implements IPriorityQueue<T> {
   private _queue: T[];
-  private _comparator: (item1: T, item2: T) => boolean;
+  private _comparator?: (item1: T, item2: T) => boolean;
 
   constructor(comparator?: (item1: T, item2: T) => boolean) {
     this._queue = [];

test/priority-queue.spec.ts

@@ -16,7 +16,7 @@ describe('testing priority queue', () => {
     });
 
     afterEach(() => {
-      p = null;
+      p = new PriorityQueue();
     });
 
     it('should return max heap of test case 1', () => {
@@ -193,7 +193,7 @@ describe('testing priority queue', () => {
     });
 
     afterEach(() => {
-      p = null;
+      p = new PriorityQueue();
     });
 
     it('should return min heap of test case 1', () => {
@@ -233,7 +233,7 @@ describe('testing priority queue', () => {
     });
 
     afterEach(() => {
-      p = null;
+      p = new PriorityQueue();
     });
 
     it('should return true - with array of numbers', () => {

tsconfig.json

@@ -5,12 +5,12 @@
   "compilerOptions": {
     "outDir": "./dist",
     "noImplicitAny": false,
-    "noImplicitUseStrict": true,
     "module": "CommonJS",
     "target": "ESNext",
     "allowJs": true,
     "moduleResolution": "node",
     "esModuleInterop": true,
+    "strict": true,
     "lib": [
       "ES2015",
       "DOM"

typings/priority-queue.d.ts

@@ -10,12 +10,12 @@ export interface IPriorityQueue<T> {
   /**
    * Retrieves, but does not remove, the head of this queue, or returns null if this queue is empty.
    */
-  top: () => T;
+  top: () => T | null;
   /**
    * Retrieves and removes the head of this queue, or returns null if this queue is empty.
    * Everytime pop element from queue, the queue is started "sift down" to rebuild the heap
    */
-  pop: () => T;
+  pop: () => T | null;
   /**
    * Returns the number of elements in this collection.
    */