Make ty: ignore to type: ignore

Author: kracekumar

litecli/completion_refresher.py

@@ -2,7 +2,7 @@
 
 import threading
 from collections import OrderedDict
-from typing import Callable
+from typing import Callable, cast
 
 from .packages.special.main import COMMANDS
 from .sqlcompleter import SQLCompleter
@@ -76,7 +76,9 @@ def _bg_refresh(
 
         # If callbacks is a single function then push it into a list.
         if callable(callbacks):
-            callbacks = [callbacks]
+            callbacks_list: list[Callable] = [callbacks]
+        else:
+            callbacks_list = list(cast(list[Callable], callbacks))
 
         while 1:
             for refresher in self.refreshers.values():
@@ -93,7 +95,7 @@ def _bg_refresh(
             # break statement.
             continue
 
-        for callback in callbacks:  # ty: ignore[not-iterable]
+        for callback in callbacks_list:
             callback(completer)
 
 

litecli/main.py

@@ -13,7 +13,7 @@
 from io import open
 
 try:
-    from sqlean import OperationalError, sqlite_version  # ty: ignore[unresolved-import]
+    from sqlean import OperationalError, sqlite_version  # type: ignore[import-untyped]
 except ImportError:
     from sqlite3 import OperationalError, sqlite_version
 from time import time
@@ -80,7 +80,8 @@ def __init__(
         self.key_bindings = c["main"]["key_bindings"]
         special.set_favorite_queries(self.config)
         self.formatter = TabularOutputFormatter(format_name=c["main"]["table_format"])
-        self.formatter.litecli = self  # ty: ignore[unresolved-attribute]
+        # self.formatter.litecli = self, ty raises unresolved-attribute, hence use dynamic assignment
+        setattr(self.formatter, "litecli", self)
         self.syntax_style = c["main"]["syntax_style"]
         self.less_chatty = c["main"].as_bool("less_chatty")
         self.show_bottom_toolbar = c["main"].as_bool("show_bottom_toolbar")
@@ -302,7 +303,7 @@ def get(key: str) -> str | None:
 
         return {x: get(x) for x in keys}
 
-    def connect(self, database: str = "") -> None:
+    def connect(self, database: str | None = "") -> None:
         cnf: dict[str, str | None] = {"database": None}
 
         cnf = self.read_my_cnf_files(cnf.keys())
@@ -509,8 +510,8 @@ def one_iteration(text: str | None = None) -> None:
                 successful = False
                 start = time()
                 res = sqlexecute.run(text)
-                # Ty complains about dynamic assignment. Since the code from the library, ignore the assignment error
-                self.formatter.query = text  # ty: ignore[invalid-assignment]
+                # Set query attribute dynamically on formatter
+                setattr(self.formatter, "query", text)
                 successful = True
                 special.unset_once_if_written()
                 # Keep track of whether or not the query is mutating. In case
@@ -523,7 +524,7 @@ def one_iteration(text: str | None = None) -> None:
             except KeyboardInterrupt:
                 try:
                     # since connection can sqlite3 or sqlean, it's hard to annotate the type for interrupt. so ignore the type hint warning.
-                    sqlexecute.conn.interrupt()  # ty: ignore[possibly-missing-attribute]
+                    sqlexecute.conn.interrupt()  # type: ignore[attr-defined]
                 except Exception as e:
                     self.echo(
                         "Encountered error while cancelling query: {}".format(e),
@@ -817,7 +818,7 @@ def run_query(self, query: str, new_line: bool = True) -> None:
         results = self.sqlexecute.run(query)
         for result in results:
             title, cur, headers, status = result
-            self.formatter.query = query  # ty: ignore[invalid-assignment]
+            setattr(self.formatter, "query", query)
             output = self.format_output(title, cur, headers)
             for line in output:
                 click.echo(line, nl=new_line)

litecli/packages/special/llm.py

@@ -26,7 +26,7 @@
 LLM_CLI_COMMANDS: list[str] = list(cli.commands.keys())
 # Mapping of model_id to None used for completion tree leaves.
 # the file name is llm.py and module name is llm, hence ty is complaining that get_models is missing.
-MODELS: dict[str, None] = {x.model_id: None for x in llm.get_models()}  # ty: ignore[unresolved-attribute]
+MODELS: dict[str, None] = {x.model_id: None for x in llm.get_models()}  # type: ignore[attr-defined]
 
 
 def run_external_cmd(

litecli/sqlexecute.py

@@ -5,8 +5,8 @@
 from typing import Any, Generator, Iterable
 
 try:
-    import sqlean as sqlite3
-    from sqlean import OperationalError  # ty: ignore[unresolved-import]
+    import sqlean as sqlite3  # type: ignore[import-untyped]
+    from sqlean import OperationalError  # type: ignore[import-untyped]
 
     sqlite3.extensions.enable_all()
 except ImportError:
@@ -88,7 +88,7 @@ def connect(self, database: str | None = None) -> None:
                 raise Exception("Path does not exist: {}".format(db_dir_name))
 
         # sqlean exposes the connect method during run-time
-        conn = sqlite3.connect(database=db_name, isolation_level=None, uri=uri)  # ty: ignore[possibly-missing-attribute]
+        conn = sqlite3.connect(database=db_name, isolation_level=None, uri=uri)  # type: ignore[attr-defined]
         conn.text_factory = lambda x: x.decode("utf-8", "backslashreplace")
         if self.conn:
             self.conn.close()

tests/test_main.py

@@ -240,10 +240,10 @@ def stub_terminal_size():
 
     old_func = shutil.get_terminal_size
 
-    shutil.get_terminal_size = stub_terminal_size  # ty: ignore[invalid-assignment]
+    shutil.get_terminal_size = stub_terminal_size  # type: ignore[assignment]
     lc = LiteCli()
     assert isinstance(lc.get_reserved_space(), int)
-    shutil.get_terminal_size = old_func
+    shutil.get_terminal_size = old_func  # type: ignore[assignment]
 
 
 @dbtest
@@ -330,7 +330,7 @@ def test_get_prompt(mock_datetime):
     assert lc.get_prompt(r"\s") == "42"
 
     # 11. Test when dbname is None => (none)
-    lc.connect(None)  # ty: ignore[invalid-argument-type]
+    lc.connect(None)
     # Simulate no DB connection and incorrect argument type
     assert lc.get_prompt(r"\d") == "(none)"
     assert lc.get_prompt(r"\f") == "(none)"

tests/test_sqlexecute.py

@@ -7,7 +7,7 @@
 from .utils import assert_result_equal, dbtest, is_expanded_output, run, set_expanded_output
 
 try:
-    from sqlean import OperationalError, ProgrammingError  # ty: ignore[unresolved-import]
+    from sqlean import OperationalError, ProgrammingError  # type: ignore[import-untyped]
 except ImportError:
     from sqlite3 import OperationalError, ProgrammingError
 

tests/utils.py

@@ -21,7 +21,7 @@
 
 
 def db_connection(dbname=":memory:"):
-    conn = sqlite3.connect(database=dbname, isolation_level=None)  # ty: ignore[possibly-missing-attribute]
+    conn = sqlite3.connect(database=dbname, isolation_level=None)  # type: ignore[attr-defined]
     return conn