Fix: Improved WhereIsCommand by handling null/whitespace paths.

Author: deanthecoder

DTC.Core

@@ -225,7 +225,7 @@ public void ProcessEvents()
         lock (m_consoleEvents)
         {
             var visualTree = GetVisualTree(Root).ToArray();
-            foreach (var consoleEvent in m_consoleEvents)
+            foreach (var consoleEvent in m_consoleEvents.ToArray())
             {
                 if (consoleEvent is KeyConsoleEvent keyEvent && keyEvent.Direction == KeyConsoleEvent.KeyDirection.Down)
                 {

G33kShell.Desktop/Console/WindowManager.cs

@@ -31,8 +31,16 @@ public ExecutableCommand([NotNull] string[] args)
 
     public bool CanExecute(DirectoryInfo cwd)
     {
-        var command = m_args.FirstOrDefault();
-        return !string.IsNullOrWhiteSpace(command) && WhereIsCommand.FindExecutables(command, cwd).Any();
+        try
+        {
+            var command = m_args.FirstOrDefault();
+            return !string.IsNullOrWhiteSpace(command) && WhereIsCommand.FindExecutables(command, cwd).Any();
+        }
+        catch
+        {
+            // Something went wrong - We can't execute the command.
+            return false;
+        }
     }
 
     protected override async Task<bool> Run(ITerminalState state)

G33kShell.Desktop/Terminal/Commands/ExecutableCommand.cs

@@ -62,13 +62,23 @@ public static IEnumerable<FileInfo> FindExecutables(string name, DirectoryInfo c
         };
         paths.AddRange(pathEnv?.Split(RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? ';' : ':') ?? Array.Empty<string>());
 
-        foreach (var dir in paths.Select(o => o.ToDir()).Where(o => o.Exists()))
+        foreach (var dir in paths.Where(o => !string.IsNullOrWhiteSpace(o)).Select(o => o.ToDir()).Where(o => o.Exists()))
         {
             var searchPattern = name;
             if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && string.IsNullOrEmpty(Path.GetExtension(name)))
                 searchPattern = name + ".*";
+
+            FileInfo[] files;
+            try
+            {
+                files = dir.GetFiles(searchPattern);
+            }
+            catch (Exception)
+            {
+                // Invalid search pattern - Assume not found.
+                files = Array.Empty<FileInfo>();
+            }
 
-            var files = dir.GetFiles(searchPattern);
             foreach (var fileInfo in files.Where(o => o.IsExecutable()))
                 yield return fileInfo;
         }

G33kShell.Desktop/Terminal/Commands/WhereIsCommand.cs

@@ -102,7 +102,7 @@ private async Task ExecuteAsync(string cmdString)
             command = (CommandBase)parsedCommand.PrimaryCommand.InstantiatedCommand;
         }
 
-        await command.SetState(this).ExecuteAsync(new CancellationToken());
+        await command.SetState(this).ExecuteAsync(CancellationToken.None);
 
         // Prepare the next prompt for input.
         PrepareNextInputPrompt();