addressed review comments

Author: ankit-patil-hubs

docs/resources/appdata_dsource.md

@@ -181,6 +181,6 @@ resource "delphix_appdata_dsource" "dsource_name" {
 
 * `sync_parameters` - (Optional) The JSON payload conforming to the snapshot parameters definition in a LUA toolkit or platform plugin.
 
-* `skip_wait_for_snapshot_creation` - (Optional) By default this resource waits for snapshot to be created post dsource creation , default behaviour can be skipped by setting this parameter to true.
+* `skip_wait_for_snapshot_creation` - (Optional) By default this resource will wait for a snapshot to be created post-dSource creation. This ensure a snapshot is available during the VDB provisioning. This behavior can be skipped by setting this parameter to `true`.
 
-* `wait_time` - (Optional) By default this resource waits for snapshot to be created for 3 minuites , this pameter can be used to set the wait_time in minutes as per need.
+* `wait_time` - (Optional) By default this resource waits 3 minutes for a snapshot to be created. Increase the integer value as needed for larger dSource snapshots. This parameter can be ignored if 'skip_wait_for_snapshot_creation' is set to `true`.

docs/resources/database_postgresql.md

@@ -1,11 +1,11 @@
 # Resource: <resource name> delphix_database_postgresql
 
-In Delphix, a databsae/source is required in the environment using which a dsource can be created.
+In the Delphix Platform, a Database (or Source Config) identifies the environment's location from which a specific source dataset can be ingested from. dSources are then created from these Databases.
 
 ## System Requirements
 
-* Data Control Tower v14.0.1+ is required for dSource management. Lower versions are not supported.
-* This Databse PostgresSql Resource only supports POSTGRES , This resource does not support Oracle, SQL Server, or SAP ASE.
+* Data Control Tower v14.0.1+ is required for database management. Lower versions are not supported.
+* The Database PostgreSQL resource only supports the Delphix PostgreSQL database type (POSTGRES). This resource does not support Oracle, SQL Server, or SAP ASE.
 
 ## Example Usage
 
@@ -27,13 +27,9 @@ resource "delphix_database_postgresql" "source" {
 
 * `repository_value` - (Required)  The Id or Name of the Repository onto which the source will be created..
 
-* `environment_value` - (Required) The Id or Name of the environment to create the source on.
+* `environment_value` - (Optional) The Id or Name of the environment to create the source on.
 
-* `engine_value` - (Required) The Id or Name of the engine to create the source on.
-
-* `id` - The Source object entity ID.
-
-* `database_type` - The type of this source database.
+* `engine_value` - (Optional) The Id or Name of the engine to create the source on.
 
 * `id` - The Source object entity ID.
 
@@ -65,12 +61,8 @@ resource "delphix_database_postgresql" "source" {
 
 * `repository` - The repository id for this source.
 
-* `recovery_model` - Recovery model of the source database (MSSql Only).
-
-* `mssql_source_type` - The type of this mssql source database (MSSql Only).
-
 * `appdata_source_type` - The type of this appdata source database (Appdata Only).
 
-* `tags` -  The tags to be created for dSource. This is a map of 2 parameters:
+* `tags` -  The tags to be created for database. This is a map of 2 parameters:
     * `key` - Key of the tag
     * `value` - Value of the tag

docs/resources/oracle_dsource.md

@@ -195,6 +195,6 @@ resource "delphix_oracle_dsource" "test_oracle_dsource" {
         * `azure_vault_secret_key` - Azure vault key in the key-value store.
         * `cyberark_vault_query_string` - Query to find a credential in the CyberArk vault.
 
-* `skip_wait_for_snapshot_creation` - (Optional) By default this resource waits for snapshot to be created post dsource creation , default behaviour can be skipped by setting this parameter to true.
+* `skip_wait_for_snapshot_creation` - (Optional) By default this resource will wait for a snapshot to be created post-dSource creation. This ensure a snapshot is available during the VDB provisioning. This behavior can be skipped by setting this parameter to `true`.
 
-* `wait_time` - (Optional) By default this resource waits for snapshot to be created for 3 minuites , this pameter can be used to set the wait_time in minutes as per need.
+* `wait_time` - (Optional) By default this resource waits 3 minutes for a snapshot to be created. Increase the integer value as needed for larger dSource snapshots. This parameter can be ignored if 'skip_wait_for_snapshot_creation' is set to `true`.

internal/provider/resource_database_postgresql.go

@@ -102,14 +102,6 @@ func resourceSource() *schema.Resource {
 				Type:     schema.TypeString,
 				Computed: true,
 			},
-			"recovery_model": {
-				Type:     schema.TypeString,
-				Computed: true,
-			},
-			"mssql_source_type": {
-				Type:     schema.TypeString,
-				Computed: true,
-			},
 			"appdata_source_type": {
 				Type:     schema.TypeString,
 				Computed: true,
@@ -232,8 +224,6 @@ func resourceDatabasePostgressqlRead(ctx context.Context, d *schema.ResourceData
 	d.Set("toolkit_id", result.GetToolkitId())
 	d.Set("is_dsource", result.GetIsDsource())
 	d.Set("repository", result.GetRepository())
-	d.Set("recovery_model", result.GetRecoveryModel())
-	d.Set("mssql_source_type", result.GetMssqlSourceType())
 	d.Set("appdata_source_type", result.GetAppdataSourceType())
 
 	return diags