Skip to content

Commit 1c4a688

Browse files
author
Uddipaan Hazarika
committed
vdb_group fix and database_name fix
1 parent 078a388 commit 1c4a688

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

internal/provider/resource_vdb.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1591,7 +1591,9 @@ func resourceVdbRead(ctx context.Context, d *schema.ResourceData, meta interface
15911591
d.Set("post_stop", flattenHooks(result.GetHooks().PostStop))
15921592
d.Set("pre_rollback", flattenHooks(result.GetHooks().PreRollback))
15931593
d.Set("post_rollback", flattenHooks(result.GetHooks().PostRollback))
1594-
d.Set("database_name", result.GetDatabaseName())
1594+
if !*result.IsAppdata {
1595+
d.Set("database_name", result.GetDatabaseName())
1596+
}
15951597
d.Set("tags", flattenTags(result.GetTags()))
15961598
d.Set("vdb_restart", result.GetVdbRestart())
15971599

internal/provider/resource_vdb_group.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ func resourceVdbGroup() *schema.Resource {
3030
},
3131
"vdb_ids": {
3232
Type: schema.TypeList,
33-
Required: true,
33+
Optional: true,
3434
Elem: &schema.Schema{
3535
Type: schema.TypeString,
3636
},
@@ -45,9 +45,9 @@ func resourceVdbGroupCreate(ctx context.Context, d *schema.ResourceData, meta in
4545

4646
client := meta.(*apiClient).client
4747

48-
apiRes, httpRes, err := client.VDBGroupsAPI.CreateVdbGroup(ctx).CreateVDBGroupRequest(*dctapi.NewCreateVDBGroupRequest(
49-
d.Get("name").(string),
50-
)).Execute()
48+
vdbGroupCreateReq := *dctapi.NewCreateVDBGroupRequest(d.Get("name").(string))
49+
vdbGroupCreateReq.SetVdbIds(toStringArray(d.Get("vdb_ids")))
50+
apiRes, httpRes, err := client.VDBGroupsAPI.CreateVdbGroup(ctx).CreateVDBGroupRequest(vdbGroupCreateReq).Execute()
5151

5252
if diags := apiErrorResponseHelper(ctx, apiRes, httpRes, err); diags != nil {
5353
return diags
@@ -74,6 +74,7 @@ func resourceVdbGroupRead(ctx context.Context, d *schema.ResourceData, meta inte
7474
apiRes, httpRes, err := client.VDBGroupsAPI.GetVdbGroup(ctx, vdbGroupId).Execute()
7575

7676
if diags := apiErrorResponseHelper(ctx, apiRes, httpRes, err); diags != nil {
77+
d.SetId("")
7778
return diags
7879
}
7980

0 commit comments

Comments
 (0)