refactor: rename 'email' to 'login' in authentication tests and login form for consistency

Author: JasonKrik

services/backend/tests/e2e/3-email-login.e2e.test.ts

@@ -27,7 +27,7 @@ describe('Email Login and Logout E2E Tests', () => {
 
     // Login with first user credentials
     const loginData = {
-      email: 'admin@example.com',
+      login: 'admin@example.com',
       password: 'SecurePassword123!'
     };
 
@@ -62,7 +62,7 @@ describe('Email Login and Logout E2E Tests', () => {
 
     // Login with second user credentials
     const loginData = {
-      email: 'user@example.com',
+      login: 'user@example.com',
       password: 'SecurePassword456!'
     };
 
@@ -114,7 +114,7 @@ describe('Email Login and Logout E2E Tests', () => {
 
   it('should reject login with invalid email', async () => {
     const invalidLoginData = {
-      email: 'nonexistent@example.com',
+      login: 'nonexistent@example.com',
       password: 'SecurePassword123!'
     };
 
@@ -129,7 +129,7 @@ describe('Email Login and Logout E2E Tests', () => {
 
   it('should reject login with invalid password', async () => {
     const invalidLoginData = {
-      email: 'admin@example.com',
+      login: 'admin@example.com',
       password: 'WrongPassword123!'
     };
 
@@ -213,7 +213,7 @@ describe('Email Login and Logout E2E Tests', () => {
 
     // Re-login with first user after logout
     const loginData = {
-      email: 'admin@example.com',
+      login: 'admin@example.com',
       password: 'SecurePassword123!'
     };
 

services/backend/tests/e2e/5-global-settings-api-access.e2e.test.ts

@@ -28,7 +28,7 @@ describe('Global Settings Access Control E2E Tests', () => {
     const adminLoginResponse = await request(server.server)
       .post('/api/auth/email/login')
       .send({
-        email: 'admin@example.com',
+        login: 'admin@example.com',
         password: 'SecurePassword123!'
       });
 
@@ -42,7 +42,7 @@ describe('Global Settings Access Control E2E Tests', () => {
     const userLoginResponse = await request(server.server)
       .post('/api/auth/email/login')
       .send({
-        email: 'user@example.com',
+        login: 'user@example.com',
         password: 'SecurePassword456!'
       });
 

services/backend/tests/e2e/6-global-settings-helpers.e2e.test.ts

@@ -35,7 +35,7 @@ describe('Global Settings Helper Methods E2E Tests', () => {
     const adminLoginResponse = await request(server.server)
       .post('/api/auth/email/login')
       .send({
-        email: 'admin@example.com',
+        login: 'admin@example.com',
         password: 'SecurePassword123!'
       });
 

services/backend/tests/e2e/7-global-enable-login.e2e.test.ts

@@ -9,11 +9,11 @@ describe('Global Enable Login E2E Tests', () => {
 
   // User credentials (matching those in 2-user-registration.e2e.test.ts and 3-email-login.e2e.test.ts)
   const adminUserCredentials = {
-    email: 'admin@example.com',
+    login: 'admin@example.com',
     password: 'SecurePassword123!',
   };
   const regularUserCredentials = {
-    email: 'user@example.com',
+    login: 'user@example.com',
     password: 'SecurePassword456!',
   };
 
@@ -82,7 +82,7 @@ describe('Global Enable Login E2E Tests', () => {
 
     expect(loginResponse.status).toBe(200);
     expect(loginResponse.body).toHaveProperty('success', true);
-    expect(loginResponse.body.user.email).toBe(regularUserCredentials.email);
+    expect(loginResponse.body.user.email).toBe(regularUserCredentials.login); // Ensure we check against the correct field if it was 'email' before
   });
 
   it('should prevent login when global.enable_login is set to false', async () => {
@@ -108,6 +108,6 @@ describe('Global Enable Login E2E Tests', () => {
 
     expect(loginResponse.status).toBe(200);
     expect(loginResponse.body).toHaveProperty('success', true);
-    expect(loginResponse.body.user.email).toBe(regularUserCredentials.email);
+    expect(loginResponse.body.user.email).toBe(regularUserCredentials.login);
   });
 });

services/frontend/src/views/Login.vue

@@ -38,7 +38,7 @@ const { t } = useI18n() // Initialize i18n composable
 // Define validation schema using Zod
 const formSchema = toTypedSchema(
   z.object({
-    email: z
+    login: z
       .string()
       .min(1, { message: t('validation.required', { field: t('login.form.email.label') }) })
       .email({ message: t('validation.email') }),
@@ -53,7 +53,7 @@ const formSchema = toTypedSchema(
 const form = useForm({
   validationSchema: formSchema,
   initialValues: {
-    email: '',
+    login: '',
     password: '',
   },
 })
@@ -101,7 +101,7 @@ const onSubmit = form.handleSubmit(async (values) => {
 
   try {
     // Use the UserService login method which handles cache clearing
-    const data = await UserService.login(values.email, values.password)
+    const data = await UserService.login(values.login, values.password)
     console.log('Login successful!', data)
 
     // Handle successful login - redirect to dashboard or home
@@ -173,7 +173,7 @@ const navigateToRegister = () => {
       <Card>
         <CardContent class="pt-6">
           <form @submit="onSubmit" class="space-y-6">
-            <FormField v-slot="{ componentField }" name="email">
+            <FormField v-slot="{ componentField }" name="login">
               <FormItem>
                 <FormLabel>{{ $t('login.form.email.label') }}</FormLabel>
                 <FormControl>