Skip to content

Commit 37a7781

Browse files
author
Lasim
committed
feat(frontend): update loading and error states in RequestsTab and ToolsTab
1 parent 7295e6c commit 37a7781

File tree

3 files changed

+4
-15
lines changed

3 files changed

+4
-15
lines changed

services/frontend/src/components/mcp-server/installation/RequestsTab.vue

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { Alert, AlertDescription } from '@/components/ui/alert'
1010
import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@/components/ui/select'
1111
import { HoverCard, HoverCardContent, HoverCardTrigger } from '@/components/ui/hover-card'
1212
import { Card } from '@/components/ui/card'
13-
import { AlertTriangle, Eye, Radio } from 'lucide-vue-next'
13+
import { AlertCircle, AlertTriangle, Eye, Radio } from 'lucide-vue-next'
1414
import type { McpInstallation } from '@/types/mcp-installations'
1515
import type { McpRequestLog } from '@/types/mcp-request-logs'
1616
@@ -203,13 +203,8 @@ onUnmounted(() => {
203203
</div>
204204
</div>
205205

206-
<!-- Loading State -->
207-
<div v-if="isLoading && requests.length === 0" class="text-muted-foreground py-8 text-center">
208-
{{ t('mcpInstallations.details.requests.loading') }}
209-
</div>
210-
211206
<!-- Empty State -->
212-
<div v-else-if="filteredRequests.length === 0" class="text-center py-12 px-6">
207+
<div v-if="filteredRequests.length === 0" class="text-center py-12 px-6">
213208
<p class="text-sm">{{ t('mcpInstallations.details.requests.emptyState.title') }}</p>
214209
<p class="mt-2 text-sm text-muted-foreground max-w-md mx-auto">
215210
{{ t('mcpInstallations.details.requests.emptyState.description') }}

services/frontend/src/components/mcp-server/installation/ToolsTab.vue

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -154,14 +154,9 @@ const pieChartOption = computed<EChartsOption>(() => {
154154
</script>
155155

156156
<template>
157-
<div>
158-
<!-- Loading State -->
159-
<div v-if="isLoading" class="text-muted-foreground">
160-
{{ t('mcpInstallations.details.tools.loading') }}
161-
</div>
162-
157+
<div v-if="!isLoading">
163158
<!-- Error State -->
164-
<Alert v-else-if="error" variant="destructive" class="mb-6">
159+
<Alert v-if="error" variant="destructive" class="mb-6">
165160
<AlertCircle class="h-4 w-4" />
166161
<AlertDescription>
167162
{{ t('mcpInstallations.details.tools.error.description', { error }) }}

services/frontend/src/i18n/locales/en/mcp-installations.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -622,7 +622,6 @@ export default {
622622
tools: {
623623
title: 'Tools',
624624
description: 'Tools discovered from this MCP server installation',
625-
loading: 'Loading tools...',
626625
noTools: {
627626
title: 'No Tools Discovered',
628627
description: 'No tools have been discovered yet for this MCP server installation. Tools are discovered automatically when the satellite starts the MCP server.'

0 commit comments

Comments
 (0)