feat: Update API routes to use preValidation instead of preHandler for global admin checks

Author: Lasim

services/backend/api-spec.json

@@ -6155,6 +6155,17 @@
           "Global Settings"
         ],
         "description": "Tests GitHub App configuration by fetching Microsoft VS Code repository information. Only global administrators can access this endpoint.",
+        "requestBody": {
+          "content": {
+            "application/json": {
+              "schema": {
+                "type": "object",
+                "properties": {},
+                "additionalProperties": true
+              }
+            }
+          }
+        },
         "security": [
           {
             "cookieAuth": []

services/backend/api-spec.yaml

@@ -4287,6 +4287,13 @@ paths:
       description: Tests GitHub App configuration by fetching Microsoft VS Code
         repository information. Only global administrators can access this
         endpoint.
+      requestBody:
+        content:
+          application/json:
+            schema:
+              type: object
+              properties: {}
+              additionalProperties: true
       security:
         - cookieAuth: []
       responses:

services/backend/src/routes/globalSettings/categories/list.ts

@@ -43,7 +43,7 @@ export default async function listCategoriesRoute(fastify: FastifyInstance) {
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request, reply) => {
     try {
       const categories = await GlobalSettingsService.getCategories();

services/backend/src/routes/globalSettings/github/test-connection.ts

@@ -69,7 +69,7 @@ export default async function githubTestConnectionRoute(fastify: FastifyInstance
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request, reply) => {
     fastify.log.info({
       operation: 'github_app_test_connection',

services/backend/src/routes/globalSettings/groups/get.ts

@@ -52,7 +52,7 @@ export default async function getGroupSettingsRoute(fastify: FastifyInstance) {
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request, reply) => {
     try {
       const { groupId } = request.params;

services/backend/src/routes/globalSettings/groups/list.ts

@@ -44,7 +44,7 @@ export default async function listGroupsRoute(fastify: FastifyInstance) {
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request: FastifyRequest, reply: FastifyReply) => {
     try {
       const groupsWithSettings = await GlobalSettingsService.getAllGroupsWithSettings();

services/backend/src/routes/globalSettings/health/check.ts

@@ -47,7 +47,7 @@ export default async function healthCheckRoute(fastify: FastifyInstance) {
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request, reply) => {
     try {
       const encryptionWorking = validateEncryption();

services/backend/src/routes/globalSettings/settings/bulk.ts

@@ -68,7 +68,7 @@ export default async function bulkGlobalSettingsRoute(fastify: FastifyInstance)
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request, reply) => {
     try {
       // Fastify has already validated request.body using BulkGlobalSettingsSchema

services/backend/src/routes/globalSettings/settings/delete.ts

@@ -55,7 +55,7 @@ export default async function deleteGlobalSettingRoute(fastify: FastifyInstance)
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request, reply) => {
     try {
       const { key } = request.params;

services/backend/src/routes/globalSettings/settings/get.ts

@@ -57,7 +57,7 @@ export default async function getGlobalSettingRoute(fastify: FastifyInstance) {
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request, reply) => {
     try {
       const { key } = request.params;