Remove urlsToWatch diagnostic check. Closes #31 (#75)

Closes #31

Author: garrytrinder

src/diagnostics.ts

@@ -32,25 +32,6 @@ export const updateDiagnostics = (
     }
   }
 
-  // check if urlsToWatch is empty
-  const urlsToWatchNode = getASTNode(
-    documentNode.children,
-    'Identifier',
-    'urlsToWatch'
-  );
-  if (
-    urlsToWatchNode &&
-    (urlsToWatchNode.value as parse.ArrayNode).children.length === 0
-  ) {
-    diagnostics.push(
-      new vscode.Diagnostic(
-        getRangeFromASTNode(urlsToWatchNode),
-        'Add at least one url to watch.',
-        vscode.DiagnosticSeverity.Error
-      )
-    );
-  }
-
   // check validity of plugins
   const pluginsNode = getASTNode(
     documentNode.children,

src/test/extension.test.ts

@@ -42,84 +42,6 @@ suite('extension', () => {
   });
 });
 
-suite('urlsToWatch', () => {
-
-  suiteSetup(async () => {
-    const context = await vscode.extensions.getExtension('garrytrinder.dev-proxy-toolkit')?.activate() as vscode.ExtensionContext;
-    await context.globalState.update('devProxyInstall', testDevProxyInstall);
-  });
-
-  teardown(async () => {
-    await vscode.commands.executeCommand('workbench.action.closeActiveEditor');
-    const context = await vscode.extensions.getExtension('garrytrinder.dev-proxy-toolkit')?.activate() as vscode.ExtensionContext;
-    await context.globalState.update('devProxyInstall', testDevProxyInstall);
-  });
-
-  test('should show error when opening document with no urlsToWatch found', async () => {
-    const fileName = 'config-urls-to-watch-required.json';
-    const filePath = path.resolve(__dirname, 'examples', fileName);
-    const document = await vscode.workspace.openTextDocument(filePath);
-    const diagnostics = vscode.languages.getDiagnostics(document.uri);
-
-    const expected = {
-      message: 'Add at least one url to watch.',
-      severity: vscode.DiagnosticSeverity.Error,
-    };
-    const actual = {
-      message: diagnostics[0]?.message,
-      severity: diagnostics[0]?.severity,
-    };
-    assert.deepStrictEqual(actual, expected);
-  });
-
-  test('should show error when document changes and has no urlsToWatch found', async () => {
-    const fileName = 'config-urls-to-watch-required.json';
-    const filePath = path.resolve(__dirname, 'examples', fileName);
-    const fileContents = fs.readFileSync(filePath, 'utf8');
-    const document = await vscode.workspace.openTextDocument({
-      language: 'json',
-      content: fileContents,
-    });
-    await sleep(1000);
-    const diagnostics = vscode.languages.getDiagnostics(document.uri);
-
-    const expected = {
-      message: 'Add at least one url to watch.',
-      severity: vscode.DiagnosticSeverity.Error,
-    };
-    const actual = {
-      message: diagnostics[0]?.message,
-      severity: diagnostics[0]?.severity,
-    };
-    assert.deepStrictEqual(actual, expected);
-  });
-
-  test('should have no error after adding a urlToWatch', async () => {
-    const fileName = 'config-urls-to-watch-required.json';
-    const filePath = path.resolve(__dirname, 'examples', fileName);
-    const document = await vscode.workspace.openTextDocument(filePath);
-    await sleep(1000);
-    const documentNode = parse(document.getText()) as parse.ObjectNode;
-    const urlsToWatchNode = getASTNode(
-      documentNode.children,
-      'Identifier',
-      'urlsToWatch'
-    );
-    const position = getStartPositionFromASTNode(
-      urlsToWatchNode?.value as parse.ArrayNode
-    );
-    const edit = new vscode.WorkspaceEdit();
-    edit.insert(document.uri, position, '"https://example.com"');
-    await vscode.workspace.applyEdit(edit);
-    const diagnostics = vscode.languages.getDiagnostics(document.uri);
-
-    const expected = 0;
-    const actual = diagnostics.length;
-    assert.strictEqual(actual, expected);
-  });
-
-});
-
 suite('isConfigFile', () => {
 
   setup(async () => {