Skip to content

Remove recommender image configuration when Goldilocks is updated to use VPA 1.4.0... #993

@github-actions

Description

@github-actions

# TODO: Remove recommender image configuration when Goldilocks is updated to use VPA 1.4.0

              name: goldilocks-vpa-admission-controller
            patch: |
              - op: remove
                path: /spec/template/spec/containers/0/args/0
              - op: remove
                path: /spec/template/spec/containers/0/args/0
  # https://github.com/FairwindsOps/charts/blob/master/stable/goldilocks/values.yaml
  values:
    # https://github.com/FairwindsOps/charts/blob/master/stable/vpa/values.yaml
    vpa:
      enabled: true
      # TODO: Remove recommender image configuration when Goldilocks is updated to use VPA 1.4.0
      recommender:
        image:
          repository: registry.k8s.io/autoscaling/vpa-recommender
          tag: 1.4.0
      # TODO: Remove updater image configuration when Goldilocks is updated to use VPA 1.4.0
      updater:
        enabled: true
        image:
          repository: registry.k8s.io/autoscaling/vpa-updater
          tag: 1.4.0
        # TODO: Remove extraArgs from updater when VPA supports InPlaceOrRecreate by default
        extraArgs:
          feature-gates: InPlaceOrRecreate=true
      # TODO: Remove admissionController image configuration when Goldilocks is updated to use VPA 1.4.0
      admissionController:
        # fix to remove unsupported tls args from admission controller
        generateCertificate: false
        image:
          repository: registry.k8s.io/autoscaling/vpa-updater
          tag: 1.4.0
        # TODO: Remove extraArgs from admissionController when VPA supports InPlaceOrRecreate by default
        extraArgs:
          feature-gates: InPlaceOrRecreate=true
    controller:

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

✅ Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions