Skip to content

Commit ce84d6e

Browse files
committed
Updated Feature Versions
1 parent db50ec2 commit ce84d6e

File tree

3 files changed

+23
-23
lines changed

3 files changed

+23
-23
lines changed

src/dotnet/install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ for aspNetCoreRuntimeVersion in $(split_csv "$ASPNETCORE_RUNTIME_VERSIONS"); do
7777
aspNetCoreRuntimeVersions+=("$aspNetCoreRuntimeVersion")
7878
done
7979

80-
# Fail fast in case of bad input to avoid unnecessary work
80+
# Fail fast in case of bad input to avoid unneccesary work
8181
# v1 of the .NET feature allowed specifying only a major version 'X' like '3'
8282
# v2 removed this ability
8383
# - because install-dotnet.sh does not support it directly

src/dotnet/scripts/vendor/dotnet-install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1545,7 +1545,7 @@ generate_regular_links() {
15451545
link_types+=("legacy")
15461546
else
15471547
legacy_download_link=""
1548-
say_verbose "Could not construct a legacy_download_link; omitting..."
1548+
say_verbose "Cound not construct a legacy_download_link; omitting..."
15491549
fi
15501550

15511551
# Check if the SDK version is already installed.

src/oryx/scripts/vendor/dotnet-install.sh

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -406,8 +406,8 @@ get_normalized_architecture_for_specific_sdk_version() {
406406

407407
if [ "$osname" == "osx" ] && [ "$architecture" == "arm64" ] && { [ "$is_version_support_arm64" = false ] || [ "$is_channel_support_arm64" = false ]; }; then
408408
#check if rosetta is installed
409-
if [ "$(/usr/bin/pgrep oahd >/dev/null 2>&1;echo $?)" -eq 0 ]; then
410-
say_verbose "Changing user architecture from '$architecture' to 'x64' because .NET SDKs prior to version 6.0 do not support arm64."
409+
if [ "$(/usr/bin/pgrep oahd >/dev/null 2>&1;echo $?)" -eq 0 ]; then
410+
say_verbose "Changing user architecture from '$architecture' to 'x64' because .NET SDKs prior to version 6.0 do not support arm64."
411411
echo "x64"
412412
return 0;
413413
else
@@ -425,7 +425,7 @@ get_normalized_architecture_for_specific_sdk_version() {
425425
is_arm64_supported() {
426426
#any channel or version that starts with the specified versions
427427
case "$1" in
428-
( "1"* | "2"* | "3"* | "4"* | "5"*)
428+
( "1"* | "2"* | "3"* | "4"* | "5"*)
429429
echo false
430430
return 0
431431
esac
@@ -585,7 +585,7 @@ is_dotnet_package_installed() {
585585
# args:
586586
# downloaded file - $1
587587
# remote_file_size - $2
588-
validate_remote_local_file_sizes()
588+
validate_remote_local_file_sizes()
589589
{
590590
eval $invocation
591591

@@ -598,8 +598,8 @@ validate_remote_local_file_sizes()
598598
elif [[ "$OSTYPE" == "darwin"* ]]; then
599599
# hardcode in order to avoid conflicts with GNU stat
600600
file_size="$(/usr/bin/stat -f '%z' "$downloaded_file")"
601-
fi
602-
601+
fi
602+
603603
if [ -n "$file_size" ]; then
604604
say "Downloaded file size is $file_size bytes."
605605

@@ -610,10 +610,10 @@ validate_remote_local_file_sizes()
610610
say "The remote and local file sizes are equal."
611611
fi
612612
fi
613-
613+
614614
else
615-
say "Either downloaded or local package size can not be measured. One of them may be corrupted."
616-
fi
615+
say "Either downloaded or local package size can not be measured. One of them may be corrupted."
616+
fi
617617
}
618618

619619
# args:
@@ -793,7 +793,7 @@ get_specific_product_version() {
793793
fi
794794
fi
795795
done
796-
796+
797797
# Getting the version number with productVersion.txt has failed. Try parsing the download link for a version number.
798798
say_verbose "Failed to get the version using productVersion.txt file. Download link will be parsed instead."
799799
specific_product_version="$(get_product_specific_version_from_download_link "$package_download_link" "$specific_version")"
@@ -858,7 +858,7 @@ get_product_specific_version_from_download_link()
858858

859859
local download_link="$1"
860860
local specific_version="$2"
861-
local specific_product_version=""
861+
local specific_product_version=""
862862

863863
if [ -z "$download_link" ]; then
864864
echo "$specific_version"
@@ -1049,9 +1049,9 @@ extract_dotnet_package() {
10491049
local folders_with_version_regex='^.*/[0-9]+\.[0-9]+[^/]+/'
10501050
find "$temp_out_path" -type f | grep -Eo "$folders_with_version_regex" | sort | copy_files_or_dirs_from_list "$temp_out_path" "$out_path" false
10511051
find "$temp_out_path" -type f | grep -Ev "$folders_with_version_regex" | copy_files_or_dirs_from_list "$temp_out_path" "$out_path" "$override_non_versioned_files"
1052-
1052+
10531053
validate_remote_local_file_sizes "$zip_path" "$remote_file_size"
1054-
1054+
10551055
rm -rf "$temp_out_path"
10561056
if [ -z ${keep_zip+x} ]; then
10571057
rm -f "$zip_path" && say_verbose "Temporary archive file $zip_path was removed"
@@ -1198,7 +1198,7 @@ downloadcurl() {
11981198
curl $curl_options -o "$out_path" "$remote_path_with_credential" 2>&1
11991199
curl_exit_code=$?
12001200
fi
1201-
1201+
12021202
if [ $curl_exit_code -gt 0 ]; then
12031203
download_error_msg="Unable to download $remote_path."
12041204
# Check for curl timeout codes
@@ -1331,7 +1331,7 @@ get_download_link_from_aka_ms() {
13311331
say_warning "Specifying quality for STS or LTS channel is not supported, the quality will be ignored."
13321332
fi
13331333

1334-
say_verbose "Retrieving primary payload URL from aka.ms for channel: '$normalized_channel', quality: '$normalized_quality', product: '$normalized_product', os: '$normalized_os', architecture: '$normalized_architecture'."
1334+
say_verbose "Retrieving primary payload URL from aka.ms for channel: '$normalized_channel', quality: '$normalized_quality', product: '$normalized_product', os: '$normalized_os', architecture: '$normalized_architecture'."
13351335

13361336
#construct aka.ms link
13371337
aka_ms_link="https://aka.ms/dotnet"
@@ -1532,14 +1532,14 @@ generate_regular_links() {
15321532

15331533
if [ "$valid_legacy_download_link" = true ]; then
15341534
say_verbose "Constructed legacy named payload URL: $legacy_download_link"
1535-
1535+
15361536
download_links+=($legacy_download_link)
15371537
specific_versions+=($specific_version)
15381538
effective_versions+=($effective_version)
15391539
link_types+=("legacy")
15401540
else
15411541
legacy_download_link=""
1542-
say_verbose "Could not construct a legacy_download_link; omitting..."
1542+
say_verbose "Cound not construct a legacy_download_link; omitting..."
15431543
fi
15441544

15451545
# Check if the SDK version is already installed.
@@ -1560,7 +1560,7 @@ print_dry_run() {
15601560

15611561
resolved_version=${specific_versions[0]}
15621562
repeatable_command="./$script_name --version "\""$resolved_version"\"" --install-dir "\""$install_root"\"" --architecture "\""$normalized_architecture"\"" --os "\""$normalized_os"\"""
1563-
1563+
15641564
if [ ! -z "$normalized_quality" ]; then
15651565
repeatable_command+=" --quality "\""$normalized_quality"\"""
15661566
fi
@@ -1857,9 +1857,9 @@ do
18571857
echo " -q,--quality <quality> Download the latest build of specified quality in the channel."
18581858
echo " -Quality"
18591859
echo " The possible values are: daily, signed, validated, preview, GA."
1860-
echo " Works only in combination with channel. Not applicable for STS and LTS channels and will be ignored if those channels are used."
1861-
echo " For SDK use channel in A.B.Cxx format. Using quality for SDK together with channel in A.B format is not supported."
1862-
echo " Supported since 5.0 release."
1860+
echo " Works only in combination with channel. Not applicable for STS and LTS channels and will be ignored if those channels are used."
1861+
echo " For SDK use channel in A.B.Cxx format. Using quality for SDK together with channel in A.B format is not supported."
1862+
echo " Supported since 5.0 release."
18631863
echo " Note: The version parameter overrides the channel parameter when any version other than 'latest' is used, and therefore overrides the quality."
18641864
echo " --internal,-Internal Download internal builds. Requires providing credentials via --feed-credential parameter."
18651865
echo " --feed-credential <FEEDCREDENTIAL> Token to access Azure feed. Used as a query string to append to the Azure feed."

0 commit comments

Comments
 (0)