From b84d99378d4f1635fba9f161a9d2ef6255aeb491 Mon Sep 17 00:00:00 2001 From: Carlos da Costa Date: Sat, 29 Nov 2025 11:55:20 -0800 Subject: [PATCH 1/3] Update plotting.py Fix plotting of nbl --- examples/seismic/plotting.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/seismic/plotting.py b/examples/seismic/plotting.py index 953290b8de..8087442396 100644 --- a/examples/seismic/plotting.py +++ b/examples/seismic/plotting.py @@ -29,7 +29,9 @@ def plot_perturbation(model, model1, colorbar=True): domain_size = 1.e-3 * np.array(model.domain_size) extent = [model.origin[0], model.origin[0] + domain_size[0], model.origin[1] + domain_size[1], model.origin[1]] - dv = np.transpose(model.vp.data) - np.transpose(model1.vp.data) + slices = tuple(slice(model.nbl, -model.nbl) for _ in range(2)) + slices1 = tuple(slice(model1.nbl, -model1.nbl) for _ in range(2)) + dv = np.transpose(model.vp.data[slices]) - np.transpose(model1.vp.data[slices1]) plot = plt.imshow(dv, animated=True, cmap=cm.jet, vmin=min(dv.reshape(-1)), vmax=max(dv.reshape(-1)), From b2d1d4fa4d61502537d32327cfd6d41df9d8a447 Mon Sep 17 00:00:00 2001 From: Carlos da Costa Date: Tue, 30 Dec 2025 16:13:27 -0800 Subject: [PATCH 2/3] fixes https://github.com/devitocodes/devito/pull/2797#discussion_r2576312970 --- examples/seismic/plotting.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/seismic/plotting.py b/examples/seismic/plotting.py index 8087442396..4eb0222f32 100644 --- a/examples/seismic/plotting.py +++ b/examples/seismic/plotting.py @@ -29,9 +29,9 @@ def plot_perturbation(model, model1, colorbar=True): domain_size = 1.e-3 * np.array(model.domain_size) extent = [model.origin[0], model.origin[0] + domain_size[0], model.origin[1] + domain_size[1], model.origin[1]] + assert model.nbl == model1.nbl, ValueError("model and model1 have different values for nbl") slices = tuple(slice(model.nbl, -model.nbl) for _ in range(2)) - slices1 = tuple(slice(model1.nbl, -model1.nbl) for _ in range(2)) - dv = np.transpose(model.vp.data[slices]) - np.transpose(model1.vp.data[slices1]) + dv = np.transpose(model.vp.data[slices]) - np.transpose(model1.vp.data[slices]) plot = plt.imshow(dv, animated=True, cmap=cm.jet, vmin=min(dv.reshape(-1)), vmax=max(dv.reshape(-1)), From 24f5fd42f211c5da89adf47577f7a5f8e3ca7ca3 Mon Sep 17 00:00:00 2001 From: Carlos da Costa Date: Sun, 11 Jan 2026 17:05:32 -0800 Subject: [PATCH 3/3] Change assertion to raise ValueError for nbl mismatch --- examples/seismic/plotting.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/seismic/plotting.py b/examples/seismic/plotting.py index 4eb0222f32..4a5bce7ad2 100644 --- a/examples/seismic/plotting.py +++ b/examples/seismic/plotting.py @@ -29,7 +29,8 @@ def plot_perturbation(model, model1, colorbar=True): domain_size = 1.e-3 * np.array(model.domain_size) extent = [model.origin[0], model.origin[0] + domain_size[0], model.origin[1] + domain_size[1], model.origin[1]] - assert model.nbl == model1.nbl, ValueError("model and model1 have different values for nbl") + if model.nbl != model1.nbl: + raise ValueError(f"{model} and {model1} have different values for nbl") slices = tuple(slice(model.nbl, -model.nbl) for _ in range(2)) dv = np.transpose(model.vp.data[slices]) - np.transpose(model1.vp.data[slices])