Skip to content

Commit 007b0c7

Browse files
Fix sql table reference in column_dictionary
* working CLI with command name d2l * Fix sql table reference in column_dictionary + Fix readme for pip install part * check precommits succeeding * Add poetry lock + requirements.txt * Clean up gitignore --------- Co-authored-by: Alex Kyrloglou <alexandros.kyrloglou@devoteam.com>
1 parent 1ad6cc7 commit 007b0c7

File tree

5 files changed

+207
-205
lines changed

5 files changed

+207
-205
lines changed

.gitignore

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ cython_debug/
159159
# be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore
160160
# and can be added to the global gitignore or merged into this file. For a more nuclear
161161
# option (not recommended) you can uncomment the following to ignore the entire idea folder.
162-
#.idea/
162+
.idea/
163163

164164
# views folder
165165
views
@@ -169,3 +169,5 @@ result.json
169169

170170
#vscode
171171
.vscode/
172+
173+
.DS_Store

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ This command-line interface (CLI) tool helps you generate LookML view files from
1111
You can install the library using:
1212

1313
```bash
14-
pip install git+ssh://git@github.com:devoteamgcloud/dataform2looker.git --force-reinstall
14+
pip install git+ssh://git@github.com/devoteamgcloud/dataform2looker.git --force-reinstall
1515
```
1616

1717
OR

dataform2looker/database_mappers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def __init__(
6565
"name": self.name,
6666
"type": self.field_type,
6767
"description": self.description,
68-
"sql": f"{{TABLE}}.{self.name}",
68+
"sql": f"${{TABLE}}.{self.name}",
6969
}
7070
if self.dimension_type == "time_dimension_group":
7171
self.column_dictionary["datatype"] = self.data_type

0 commit comments

Comments
 (0)