CommentEnhancer now just has tableRow(spot: Spot): ReactNode instead of title/icon

Author: nedtwigg

browser-extension/src/entrypoints/popup/main.tsx

@@ -68,9 +68,8 @@ function SpotRow({ commentState, onClick }: SpotRowProps) {
     >
       <TableCell className='p-3'>
         <div className='flex items-center gap-2'>
-          <span className='text-lg'>{enhancer.tableIcon(commentState.spot)}</span>
           <div className='font-medium text-sm text-foreground overflow-hidden text-ellipsis whitespace-nowrap'>
-            {enhancer.tableTitle(commentState.spot)}
+            {enhancer.tableRow(commentState.spot)}
           </div>
         </div>
       </TableCell>

browser-extension/src/lib/enhancer.ts

@@ -41,7 +41,6 @@ export interface CommentEnhancer<Spot extends CommentSpot = CommentSpot> {
    * exactly once since pageload before this gets called.
    */
   enhance(textarea: HTMLTextAreaElement, spot: Spot): OverTypeInstance
-
-  tableIcon(spot: Spot): string
-  tableTitle(spot: Spot): ReactNode
+  /** Returns a ReactNode which will be displayed in the table row. */
+  tableRow(spot: Spot): ReactNode
 }

browser-extension/src/lib/enhancers/github/githubIssueAddComment.tsx

@@ -55,7 +55,7 @@ export class GitHubIssueAddCommentEnhancer implements CommentEnhancer<GitHubIssu
     })[0]!
   }
 
-  tableTitle(spot: GitHubIssueAddCommentSpot): React.ReactNode {
+  tableRow(spot: GitHubIssueAddCommentSpot): React.ReactNode {
     const { slug, number } = spot
     return (
       <span>
@@ -64,12 +64,4 @@ export class GitHubIssueAddCommentEnhancer implements CommentEnhancer<GitHubIssu
       </span>
     )
   }
-
-  tableIcon(_: GitHubIssueAddCommentSpot): string {
-    return '🔄' // PR icon TODO: icon urls in /public
-  }
-
-  buildUrl(spot: GitHubIssueAddCommentSpot): string {
-    return `https://${spot.domain}/${spot.slug}/issue/${spot.number}`
-  }
 }

browser-extension/src/lib/enhancers/github/githubPRAddComment.tsx

@@ -59,7 +59,7 @@ export class GitHubPRAddCommentEnhancer implements CommentEnhancer<GitHubPRAddCo
     })[0]!
   }
 
-  tableTitle(spot: GitHubPRAddCommentSpot): React.ReactNode {
+  tableRow(spot: GitHubPRAddCommentSpot): React.ReactNode {
     const { slug, number } = spot
     return (
       <span>
@@ -68,12 +68,4 @@ export class GitHubPRAddCommentEnhancer implements CommentEnhancer<GitHubPRAddCo
       </span>
     )
   }
-
-  tableIcon(_: GitHubPRAddCommentSpot): string {
-    return '🔄' // PR icon TODO: icon urls in /public
-  }
-
-  buildUrl(spot: GitHubPRAddCommentSpot): string {
-    return `https://${spot.domain}/${spot.slug}/pull/${spot.number}`
-  }
 }