Skip to content

Commit dcfa6fa

Browse files
committed
Adapt the new github types to our domain.
1 parent 18fd786 commit dcfa6fa

File tree

3 files changed

+16
-14
lines changed

3 files changed

+16
-14
lines changed

browser-extension/src/lib/enhancers/github/githubIssueNewComment.ts renamed to browser-extension/src/lib/enhancers/github/githubIssueNewComment.tsx

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,14 @@ export class GitHubIssueNewCommentEnhancer implements CommentEnhancer<GitHubIssu
5252
})[0]!
5353
}
5454

55-
tableTitle(spot: GitHubIssueNewCommentSpot): string {
55+
tableRow(spot: GitHubIssueNewCommentSpot): React.ReactNode {
5656
const { slug } = spot
57-
return `${slug} New Issue`
58-
}
59-
60-
tableIcon(_: GitHubIssueNewCommentSpot): string {
61-
return '🔄' // PR icon TODO: icon urls in /public
57+
return (
58+
<>
59+
<span>New Issue</span>
60+
<span className='font-mono text-sm text-muted-foreground' > {slug} </span>
61+
</>
62+
)
6263
}
6364

6465
buildUrl(spot: GitHubIssueNewCommentSpot): string {

browser-extension/src/lib/enhancers/github/githubPRAddComment.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,10 @@ export class GitHubPRAddCommentEnhancer implements CommentEnhancer<GitHubPRAddCo
6565
tableRow(spot: GitHubPRAddCommentSpot): React.ReactNode {
6666
const { slug, number } = spot
6767
return (
68-
<span>
68+
<>
6969
<span className='font-mono text-sm text-muted-foreground'>{slug}</span>
7070
<span className='ml-2 font-medium'>PR #{number}</span>
71-
</span>
71+
</>
7272
)
7373
}
7474
}

browser-extension/src/lib/enhancers/github/githubPRNewComment.ts renamed to browser-extension/src/lib/enhancers/github/githubPRNewComment.tsx

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,14 @@ export class GitHubPRNewCommentEnhancer implements CommentEnhancer<GitHubPRNewCo
5757
})[0]!
5858
}
5959

60-
tableTitle(spot: GitHubPRNewCommentSpot): string {
60+
tableRow(spot: GitHubPRNewCommentSpot): React.ReactNode {
6161
const { slug } = spot
62-
return `${slug} New Issue`
63-
}
64-
65-
tableIcon(_: GitHubPRNewCommentSpot): string {
66-
return '🔄' // PR icon TODO: icon urls in /public
62+
return (
63+
<>
64+
<span>New PR</span>
65+
<span className='font-mono text-sm text-muted-foreground' > {slug} </span>
66+
</>
67+
)
6768
}
6869

6970
buildUrl(spot: GitHubPRNewCommentSpot): string {

0 commit comments

Comments
 (0)