Use project.layout instead of buildDir and static strings

Author: welandaz

gradle/java-setup.gradle

@@ -26,8 +26,8 @@ tasks.named('spotbugsTest') {
 }
 
 tasks.withType(com.github.spotbugs.snom.SpotBugsTask).configureEach {
-	outputs.file("$buildDir/reports/spotbugs/${it.name}.html")
-	outputs.file("$buildDir/spotbugs/auxclasspath/${it.name}")
+	outputs.file(project.layout.buildDirectory.file("reports/spotbugs/${it.name}.html"))
+	outputs.file(project.layout.buildDirectory.file("spotbugs/auxclasspath/${it.name}"))
 	reports {
 		html.enabled = true
 	}

plugin-maven/build.gradle

@@ -24,7 +24,6 @@ visteg {
 import com.github.mustachejava.DefaultMustacheFactory
 
 import java.nio.file.Files
-import java.nio.file.Paths
 
 import static java.nio.charset.StandardCharsets.UTF_8
 import static java.nio.file.StandardOpenOption.CREATE
@@ -35,10 +34,8 @@ version = spotlessChangelog.versionNext
 apply from: rootProject.file("gradle/java-setup.gradle")
 apply from: rootProject.file("gradle/java-publish.gradle")
 
-final PROJECT_DIR = project.projectDir.toString()
-final BUILD_DIR = project.buildDir.toString()
-final MAVEN_PROJECT_DIR = "${BUILD_DIR}/mavenProject"
-final LOCAL_MAVEN_REPO_DIR = "${BUILD_DIR}/localMavenRepository"
+final MAVEN_PROJECT_DIR = project.layout.buildDirectory.dir("mavenProject").get()
+final LOCAL_MAVEN_REPO_DIR = project.layout.buildDirectory.dir("localMavenRepository").get()
 
 def mvnw(String args) {
 	boolean isWin = System.getProperty('os.name').toLowerCase().contains('win')
@@ -93,7 +90,7 @@ dependencies {
 
 task copySourceFiles(type: Sync) {
 	from "src/main/java"
-	into "${MAVEN_PROJECT_DIR}/src/main/java"
+	into MAVEN_PROJECT_DIR.dir("src/main/java")
 }
 
 task copyMvnw(type: Copy, dependsOn: copySourceFiles) {
@@ -120,7 +117,7 @@ libs.each {
 		workingDir MAVEN_PROJECT_DIR
 
 		inputs.file(file)
-		outputs.dir(project.file("${LOCAL_MAVEN_REPO_DIR}/${groupId.replace('.', '/')}/${artifactId}/${version}"))
+		outputs.dir(LOCAL_MAVEN_REPO_DIR.file(groupId.replace('.', '/') + "/" + artifactId + "/" + version))
 		commandLine mvnw("org.apache.maven.plugins:maven-install-plugin:2.3.1:install-file " +
 				"-Dfile=${file} " +
 				"-DgroupId=${groupId} " +
@@ -135,7 +132,7 @@ libs.each {
 }
 
 task createPomXml(dependsOn: installLocalDependencies) {
-	def newPomXml = Paths.get(MAVEN_PROJECT_DIR, "pom.xml")
+	def newPomXml = MAVEN_PROJECT_DIR.file("pom.xml").asFile.toPath()
 
 	outputs.file(newPomXml)
 	doLast {
@@ -158,7 +155,7 @@ task createPomXml(dependsOn: installLocalDependencies) {
 			additionalDependencies    : additionalDependencies
 		]
 
-		def pomXmlTemplate = Paths.get(PROJECT_DIR, "src/test/resources/pom-build.xml.mustache")
+		def pomXmlTemplate = project.layout.projectDirectory.file("src/test/resources/pom-build.xml.mustache").asFile.toPath()
 
 		Files.newBufferedReader(pomXmlTemplate).withCloseable { reader ->
 			Files.newBufferedWriter(newPomXml, UTF_8, CREATE, TRUNCATE_EXISTING).withCloseable { writer ->
@@ -183,7 +180,7 @@ task runMavenBuild(type: Exec, dependsOn: [
 
 jar.setActions Arrays.asList()
 jar.dependsOn(runMavenBuild)
-File jarIn = file("${MAVEN_PROJECT_DIR}/target/spotless-maven-plugin-${version}.jar")
+File jarIn = MAVEN_PROJECT_DIR.file("target/spotless-maven-plugin-${version}.jar").asFile
 File jarOut = jar.archivePath
 jar.inputs.file(jarIn)
 jar.outputs.file(jarOut)
@@ -196,7 +193,7 @@ test { useJUnitPlatform() }
 apply from: rootProject.file('gradle/special-tests.gradle')
 
 tasks.withType(Test) {
-	systemProperty "localMavenRepositoryDir", LOCAL_MAVEN_REPO_DIR
+	systemProperty "localMavenRepositoryDir", LOCAL_MAVEN_REPO_DIR.asFile
 	systemProperty "spotlessMavenPluginVersion", project.version
 	dependsOn(jar)
 }