Fix several issues reported by pyflakes.

Add assert statements for intentionally unused variables.

Author: pavoljuhas

diffpy/Structure/Parsers/P_cif.py

@@ -438,8 +438,8 @@ def _parse_space_group_symop_operation_xyz(self, block):
             sym_loop_name = sym_loop_name[0]
             sym_loop = block.GetLoop(sym_loop_name)
             for eqxyz in sym_loop[sym_loop_name]:
-                op = getSymOp(eqxyz)
-                symop_list.append(op)
+                opcif = getSymOp(eqxyz)
+                symop_list.append(opcif)
         # determine space group number
         sg_nameHall = (block.get('_space_group_name_Hall', '') or
                 block.get('_symmetry_space_group_name_Hall', ''))

diffpy/Structure/Parsers/__init__.py

@@ -35,6 +35,9 @@
 from diffpy.Structure.Parsers.structureparser import StructureParser
 from diffpy.Structure.Parsers.parser_index_mod import parser_index
 
+# silence pyflakes checker
+assert StructureParser
+
 def getParser(format, **kw):
     """Return Parser instance for a given structure format.
 

diffpy/Structure/SymmetryUtilities.py

@@ -228,7 +228,7 @@ def expandPosition(spacegroup, xyz, sgoffset=[0,0,0], eps=None):
         # here tpl is inside site_symops
         site_symops[tpl].append(symop)
     # pos_symops is nested list of symops associated with each position
-    pos_symops = [ site_symops[pos2tuple(pos)] for pos in positions ]
+    pos_symops = [site_symops[pos2tuple(p)] for p in positions]
     multiplicity = len(positions)
     return positions, pos_symops, multiplicity
 

diffpy/Structure/__init__.py

@@ -59,4 +59,13 @@ def loadStructure(filename, fmt='auto', **kw):
     rv = p.parseFile(filename)
     return rv
 
+# silence pyflakes checker
+assert (StructureFormatError and
+        LatticeError and SymmetryError and IsotropyError)
+assert Atom
+assert Lattice
+assert Structure
+assert PDFFitStructure
+assert __version__ or True
+
 # End of file

diffpy/Structure/expansion/__init__.py

@@ -24,4 +24,7 @@
 
 from diffpy.Structure.expansion.supercell_mod import supercell
 
+# silence pyflakes checker
+assert supercell
+
 # End of file