Skip to content

Commit e9a3113

Browse files
committed
Catch expected wavelength warnings
1 parent d5d3bf7 commit e9a3113

File tree

2 files changed

+17
-6
lines changed

2 files changed

+17
-6
lines changed

tests/test_diffraction_objects.py

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212

1313

1414
@pytest.mark.parametrize(
15-
"do_args_1, do_args_2, expected_equality",
15+
"do_args_1, do_args_2, expected_equality, warning_expected",
1616
[
17-
# Test when __eqal__ returns True and False
17+
# Test when __eq__ returns True and False
1818
# Identical args, expect equality
1919
(
2020
{
@@ -36,6 +36,7 @@
3636
"metadata": {"thing1": 1},
3737
},
3838
True,
39+
False
3940
),
4041
( # Different names, expect inequality
4142
{
@@ -53,6 +54,7 @@
5354
"metadata": {"thing1": 1, "thing2": "thing2"},
5455
},
5556
False,
57+
True
5658
),
5759
( # One without wavelength, expect inequality
5860
{
@@ -69,6 +71,7 @@
6971
"metadata": {"thing1": 1, "thing2": "thing2"},
7072
},
7173
False,
74+
True
7275
),
7376
( # Different wavelengths, expect inequality
7477
{
@@ -86,6 +89,7 @@
8689
"metadata": {"thing1": 1, "thing2": "thing2"},
8790
},
8891
False,
92+
False
8993
),
9094
( # Different scat_quantity, expect inequality
9195
{
@@ -103,6 +107,7 @@
103107
"metadata": {"thing1": 1, "thing2": "thing2"},
104108
},
105109
False,
110+
True
106111
),
107112
( # Different q xarray values, expect inequality
108113
{
@@ -117,6 +122,7 @@
117122
"metadata": {"thing1": 1, "thing2": "thing2"},
118123
},
119124
False,
125+
True
120126
),
121127
( # Different metadata, expect inequality
122128
{
@@ -132,12 +138,18 @@
132138
"metadata": {"thing1": 1, "thing2": "thing2"},
133139
},
134140
False,
141+
True
135142
),
136143
],
137144
)
138-
def test_diffraction_objects_equality(do_args_1, do_args_2, expected_equality):
139-
do_1 = DiffractionObject(**do_args_1)
140-
do_2 = DiffractionObject(**do_args_2)
145+
def test_diffraction_objects_equality(do_args_1, do_args_2, expected_equality, warning_expected, wavelength_warning_msg):
146+
if warning_expected:
147+
with pytest.warns(UserWarning, match=re.escape(wavelength_warning_msg)):
148+
do_1 = DiffractionObject(**do_args_1)
149+
do_2 = DiffractionObject(**do_args_2)
150+
else:
151+
do_1 = DiffractionObject(**do_args_1)
152+
do_2 = DiffractionObject(**do_args_2)
141153
assert (do_1 == do_2) == expected_equality
142154

143155

tests/test_transforms.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
],
2828
)
2929
def test_q_to_tth(wavelength, q, expected_tth, wavelength_warning_msg):
30-
3130
if wavelength is None:
3231
with pytest.warns(UserWarning, match=re.escape(wavelength_warning_msg)):
3332
actual_tth = q_to_tth(q, wavelength)

0 commit comments

Comments
 (0)