Always throw when registering existing prototype.

Remove checks for equal object type.  This allows to correctly
handle Python-derived classes, which appeared as the same type
in C++.

Author: pavoljuhas

src/diffpy/HasClassRegistry.ipp

@@ -35,9 +35,6 @@ bool HasClassRegistry<TBase>::registerThisType() const
     RegistryStorage& reg = getRegistry();
     if (reg.count(this->type()))
     {
-        // do nothing when registering the same class twice
-        const TBase& regprot = *(reg[this->type()]);
-        if (typeid(*this) == typeid(regprot))    return true;
         // raise exception if trying to register a different class
         ostringstream emsg;
         emsg << "Prototype type '" << this->type() <<

src/tests/TestHasClassRegistry.hpp

@@ -46,6 +46,7 @@ class TestHasClassRegistry : public CxxTest::TestSuite
         void tearDown()
         {
             // restore SFTXray registration if removed in some test.
+            msftb->deregisterType(msftb->type());
             msftb->registerThisType();
             TS_ASSERT(ScatteringFactorTable::isRegisteredType("X"));
             TS_ASSERT(ScatteringFactorTable::isRegisteredType("xray"));