Revert "Merge branch 'develop' into feat/repos-webhooks"

This reverts commit 1ac8483, reversing
changes made to ab529a6.

Author: ZIJ

backend/controllers/github.go

@@ -92,20 +92,6 @@ func (d DiggerController) GithubAppWebHook(c *gin.Context) {
 			c.String(http.StatusAccepted, "Failed to handle webhook event.")
 			return
 		}
-	case *github.InstallationRepositoriesEvent:
-		slog.Info("Processing InstallationRepositoriesEvent",
-			"action", *event.Action,
-			"installationId", *event.Installation.ID,
-			"repositoriesAdded", len(event.RepositoriesAdded),
-			"repositoriesRemoved", len(event.RepositoriesRemoved),
-		)
-
-		err := handleInstallationRepositoriesEvent(event, appId64)
-		if err != nil {
-			slog.Error("Failed to handle installation repositories event", "error", err)
-			c.String(http.StatusAccepted, "Failed to handle webhook event.")
-			return
-		}
 	case *github.PushEvent:
 		slog.Info("Processing PushEvent",
 			"repo", *event.Repo.FullName,

backend/controllers/github_callback.go

@@ -25,19 +25,13 @@ func (d DiggerController) GithubAppCallbackPage(c *gin.Context) {
 		c.String(http.StatusBadRequest, "installation_id parameter for github app is empty")
 		return
 	}
-
 	//setupAction := c.Request.URL.Query()["setup_action"][0]
 	codeParams, codeExists := c.Request.URL.Query()["code"]
-
-	// Code parameter is only provided for fresh installations, not for updates
-	// If code is missing, this is likely an update - just show success page
-	// The actual repository changes will be handled by the InstallationRepositoriesEvent webhook
 	if !codeExists || len(codeParams) == 0 {
-		slog.Info("No code parameter - likely an installation update, showing success page")
-		c.HTML(http.StatusOK, "github_success.tmpl", gin.H{})
+		slog.Error("There was no code in the url query parameters")
+		c.String(http.StatusBadRequest, "could not find the code query parameter for github app")
 		return
 	}
-
 	code := codeParams[0]
 	if len(code) < 1 {
 		slog.Error("Code parameter is empty")

backend/controllers/github_test.go

@@ -866,34 +866,3 @@ func TestJobsTreeWithThreeLevels(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Equal(t, result["333"].DiggerJobID, parentLinks[0].ParentDiggerJobId)
 }
-
-func TestHandleInstallationRepositoriesEvent(t *testing.T) {
-	teardownSuite, database := setupSuite(t)
-	defer teardownSuite(t)
-
-	// Test repositories added event
-	var addedEvent github.InstallationRepositoriesEvent
-	err := json.Unmarshal([]byte(installationRepositoriesAddedPayload), &addedEvent)
-	assert.NoError(t, err)
-
-	err = handleInstallationRepositoriesEvent(&addedEvent, 360162)
-	assert.NoError(t, err)
-
-	// Verify repo was added
-	installation, err := database.GetGithubAppInstallationByIdAndRepo(41584295, "diggerhq/test-github-action")
-	assert.NoError(t, err)
-	assert.NotNil(t, installation)
-	assert.Equal(t, "diggerhq/test-github-action", installation.Repo)
-
-	// Test repositories removed event
-	var removedEvent github.InstallationRepositoriesEvent
-	err = json.Unmarshal([]byte(installationRepositoriesDeletedPayload), &removedEvent)
-	assert.NoError(t, err)
-
-	err = handleInstallationRepositoriesEvent(&removedEvent, 360162)
-	assert.NoError(t, err)
-
-	// Verify repo was removed (soft deleted)
-	installation, err = database.GetGithubAppInstallationByIdAndRepo(41584295, "diggerhq/test-github-action")
-	assert.Error(t, err) // Should error because repo is deleted
-}

docs/ce/howto/noise-reduction.mdx

@@ -90,7 +90,6 @@
           {
             "group": "How To",
             "pages": [
-              "ce/howto/noise-reduction",
               "ce/howto/specify-terraform-version",
               "ce/howto/caching-strategies",
               "ce/howto/apply-on-merge",