Skip to content

Commit 1de5057

Browse files
committed
Apply django-upgrade fixes
1 parent e4cdeb9 commit 1de5057

File tree

3 files changed

+11
-12
lines changed

3 files changed

+11
-12
lines changed

simple_history/tests/admin.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
)
2222

2323

24+
@admin.register(Person)
2425
class PersonAdmin(SimpleHistoryAdmin):
2526
def has_change_permission(self, request, obj=None):
2627
return False
@@ -29,17 +30,20 @@ def has_view_permission(self, request, obj=None):
2930
return False
3031

3132

33+
@admin.register(Choice)
3234
class ChoiceAdmin(SimpleHistoryAdmin):
3335
history_list_display = ["votes"]
3436

3537

38+
@admin.register(FileModel)
3639
class FileModelAdmin(SimpleHistoryAdmin):
3740
def test_method(self, obj):
3841
return "test_method_value"
3942

4043
history_list_display = ["title", "test_method"]
4144

4245

46+
@admin.register(Planet)
4347
class PlanetAdmin(SimpleHistoryAdmin):
4448
def test_method(self, obj):
4549
return "test_method_value"
@@ -63,20 +67,16 @@ def place_display(place: Place) -> SafeString:
6367
return mark_safe(f"<b>{place.name}</b>")
6468

6569

70+
@admin.register(PollWithManyToMany)
6671
class PollWithManyToManyAdmin(SimpleHistoryAdmin):
6772
def get_historical_record_context_helper(self, request, historical_record):
6873
return HistoricalPollWithManyToManyContextHelper(self.model, historical_record)
6974

7075

7176
admin.site.register(Book, SimpleHistoryAdmin)
72-
admin.site.register(Choice, ChoiceAdmin)
7377
admin.site.register(ConcreteExternal, SimpleHistoryAdmin)
7478
admin.site.register(Document, SimpleHistoryAdmin)
7579
admin.site.register(Employee, SimpleHistoryAdmin)
7680
admin.site.register(ExternalModelWithCustomUserIdField, SimpleHistoryAdmin)
77-
admin.site.register(FileModel, FileModelAdmin)
7881
admin.site.register(Paper, SimpleHistoryAdmin)
79-
admin.site.register(Person, PersonAdmin)
80-
admin.site.register(Planet, PlanetAdmin)
8182
admin.site.register(Poll, SimpleHistoryAdmin)
82-
admin.site.register(PollWithManyToMany, PollWithManyToManyAdmin)

simple_history/tests/tests/test_utils.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,6 @@ def test_bulk_update_history_with_batch_size(self):
495495
self.assertEqual(Poll.objects.count(), 5)
496496
self.assertEqual(Poll.history.filter(history_type="~").count(), 5)
497497

498-
@skipUnless(django.VERSION >= (4, 0), "Requires Django 4.0 or above")
499498
def test_bulk_update_with_history_returns_rows_updated(self):
500499
rows_updated = bulk_update_with_history(
501500
self.data,

simple_history/tests/urls.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from django.contrib import admin
2-
from django.urls import path, re_path
2+
from django.urls import path
33

44
from simple_history.tests.view import (
55
BucketDataRegisterRequestUserCreate,
@@ -29,8 +29,8 @@
2929
BucketDataRegisterRequestUserCreate.as_view(),
3030
name="bucket_data-add",
3131
),
32-
re_path(
33-
r"^bucket_data/(?P<pk>[0-9]+)/$",
32+
path(
33+
"bucket_data/<int:pk>/",
3434
BucketDataRegisterRequestUserDetail.as_view(),
3535
name="bucket_data-detail",
3636
),
@@ -40,9 +40,9 @@
4040
PollWithHistoricalIPAddressCreate.as_view(),
4141
name="pollip-add",
4242
),
43-
re_path(r"^poll/(?P<pk>[0-9]+)/$", PollUpdate.as_view(), name="poll-update"),
44-
re_path(r"^poll/(?P<pk>[0-9]+)/delete/$", PollDelete.as_view(), name="poll-delete"),
45-
re_path(r"^polls/(?P<pk>[0-9]+)/$", PollDetail.as_view(), name="poll-detail"),
43+
path("poll/<int:pk>/", PollUpdate.as_view(), name="poll-update"),
44+
path("poll/<int:pk>/delete/", PollDelete.as_view(), name="poll-delete"),
45+
path("polls/<int:pk>/", PollDetail.as_view(), name="poll-detail"),
4646
path("polls/", PollList.as_view(), name="poll-list"),
4747
path("polls-bulk-create/", PollBulkCreateView.as_view(), name="poll-bulk-create"),
4848
path(

0 commit comments

Comments
 (0)