Allow historical tracking to be set on abstract bases

Author: macro1

simple_history/models.py

@@ -49,7 +49,8 @@ def __init__(self, verbose_name=None, bases=(models.Model,),
     def contribute_to_class(self, cls, name):
         self.manager_name = name
         self.module = cls.__module__
-        models.signals.class_prepared.connect(self.finalize, sender=cls)
+        self.cls = cls
+        models.signals.class_prepared.connect(self.finalize, weak=False)
         self.add_extra_methods(cls)
 
     def add_extra_methods(self, cls):
@@ -69,6 +70,11 @@ def save_without_historical_record(self, *args, **kwargs):
                 save_without_historical_record)
 
     def finalize(self, sender, **kwargs):
+        try:
+            if not issubclass(sender, self.cls):
+                return
+        except AttributeError:  # called via `register`
+            pass
         history_model = self.create_history_model(sender)
         module = importlib.import_module(self.module)
         setattr(module, history_model.__name__, history_model)

simple_history/tests/models.py

@@ -277,3 +277,14 @@ class ContactRegister(models.Model):
     email = models.EmailField(max_length=255, unique=True)
 
 register(ContactRegister, table_name='contacts_register_history')
+
+
+class TrackedAbstractBase(models.Model):
+    history = HistoricalRecords()
+
+    class Meta:
+        abstract = True
+
+
+class Tracked(TrackedAbstractBase):
+    pass

simple_history/tests/tests/test_models.py

@@ -19,7 +19,7 @@
     ExternalModel1, ExternalModel3, UnicodeVerboseName, HistoricalChoice,
     HistoricalState, HistoricalCustomFKError, Series, SeriesWork, PollInfo,
     UserAccessorDefault, UserAccessorOverride, Employee, Country, Province,
-    City, Contact, ContactRegister
+    City, Contact, ContactRegister, Tracked
 )
 from ..external.models import ExternalModel2, ExternalModel4
 
@@ -783,3 +783,9 @@ def test_custom_table_name_from_register(self):
             self.get_table_name(ContactRegister.history),
             'contacts_register_history',
         )
+
+
+class TestAbstractHistoricalBaseModel(TestCase):
+
+    def test_historical_abstract(self):
+        Tracked.history.all()