Add test to verify if is possible to exclude fields

Author: joaojunior

simple_history/models.py

@@ -134,14 +134,20 @@ def create_history_model(self, model):
         return python_2_unicode_compatible(
             type(str(name), self.bases, attrs))
 
+    def fields_included(self, model):
+        fields = []
+        for field in model._meta.fields:
+            if field.name not in self.excluded_fields:
+                fields.append(field)
+        return fields
+
     def copy_fields(self, model):
         """
         Creates copies of the model's original fields, returning
         a dictionary mapping field name to copied field object.
         """
         fields = {}
-        fields_to_copy = set(model._meta.fields) - set(self.excluded_fields)
-        for field in fields_to_copy:
+        for field in self.fields_included(model):
             field = copy.copy(field)
             try:
                 field.remote_field = copy.copy(field.remote_field)
@@ -250,7 +256,7 @@ def create_historical_record(self, instance, history_type):
         history_user = self.get_history_user(instance)
         manager = getattr(instance, self.manager_name)
         attrs = {}
-        for field in instance._meta.fields:
+        for field in self.fields_included(instance):
             attrs[field.attname] = getattr(instance, field.attname)
         manager.create(history_date=history_date, history_type=history_type,
                        history_user=history_user, **attrs)

simple_history/tests/models.py

@@ -18,6 +18,13 @@ class Poll(models.Model):
     history = HistoricalRecords()
 
 
+class PollWithExcludeFields(models.Model):
+    question = models.CharField(max_length=200)
+    pub_date = models.DateTimeField('date published')
+
+    history = HistoricalRecords(excluded_fields=['pub_date'])
+
+
 class Temperature(models.Model):
     location = models.CharField(max_length=200)
     temperature = models.IntegerField()

simple_history/tests/tests/test_models.py

@@ -23,6 +23,7 @@
     TrackedAbstractBaseA, TrackedAbstractBaseB,
     TrackedWithAbstractBase, TrackedWithConcreteBase,
     InheritTracking1, InheritTracking2, InheritTracking3, InheritTracking4,
+    PollWithExcludeFields,
 )
 from ..external.models import ExternalModel2, ExternalModel4
 
@@ -318,6 +319,14 @@ def test_foreignkey_primarykey(self):
         poll_info = PollInfo(poll=poll)
         poll_info.save()
 
+    def test_model_with_excluded_fields(self):
+        p = PollWithExcludeFields(question="what's up?", pub_date=today)
+        p.save()
+        history = PollWithExcludeFields.history.all()[0]
+        all_fields_names = history._meta.get_all_field_names()
+        self.assertIn('question', all_fields_names)
+        self.assertNotIn('pub_date', all_fields_names)
+
 
 class RegisterTest(TestCase):
     def test_register_no_args(self):