Skip to content

Commit d89a77e

Browse files
authored
fix ex38 error handling and add WhatsApp to ex37 (#115)
* show error message displayed and roll forward admin api sdk * WhatsApp updates to ex37 * use the manifest to pull string values
1 parent b057e88 commit d89a77e

File tree

6 files changed

+19
-8
lines changed

6 files changed

+19
-8
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
<rooms.version>1.4.3</rooms.version>
3131
<click.version> 1.4.0</click.version>
3232
<monitor.version>1.3.0</monitor.version>
33-
<admin.version>1.2.0</admin.version>
33+
<admin.version>1.3.0</admin.version>
3434
<swagger-core-version>2.2.8</swagger-core-version>
3535
<jackson-version>2.14.2</jackson-version>
3636
<jersey2.version>3.0.9</jersey2.version>

src/main/java/com/docusign/common/WorkArguments.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ public class WorkArguments {
5252
private UUID formGroupId;
5353
private String startDate;
5454
private String endDate;
55+
private String deliveryMethod;
5556
private String ccPhoneNumber;
5657
private String countryCode;
5758
private String ccCountryCode;

src/main/java/com/docusign/controller/eSignature/examples/EG037ControllerSMSDelivery.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ protected Object doWork(WorkArguments args, ModelMap model,
5656
args.getCountryCode(),
5757
args.getPhoneNumber(),
5858
args.getSignerName(),
59+
args.getDeliveryMethod(),
5960
args.getCcCountryCode(),
6061
args.getCcPhoneNumber(),
6162
args.getCcName(),

src/main/java/com/docusign/controller/eSignature/examples/EG038ControllerResponsiveSigning.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,12 @@ protected Object doWork(WorkArguments args, ModelMap model,
7474

7575

7676
} catch (ApiException apiException) {
77+
System.out.println(apiException.getMessage());
7778
DoneExample.createDefault(this.title)
78-
.withMessage(FEATURE_WAS_DISABLED)
79+
.withMessage("Feature Not Enabled")
80+
.withFixingInstructions(FEATURE_WAS_DISABLED)
7981
.addToModel(model, config);
82+
return ERROR_PAGE;
8083
}
8184

8285
return new RedirectView(viewUrl.getUrl());

src/main/java/com/docusign/controller/eSignature/services/SMSDeliveryService.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
package com.docusign.controller.eSignature.services;
22

3-
import com.docusign.common.WorkArguments;
43
import com.docusign.controller.eSignature.examples.EnvelopeHelpers;
5-
import com.docusign.core.common.DocumentType;
64
import com.docusign.esign.api.EnvelopesApi;
75
import com.docusign.esign.client.ApiException;
86
import com.docusign.esign.model.*;
97

108
import java.io.IOException;
119
import java.util.Arrays;
12-
import java.util.Collections;
1310

1411
public final class SMSDeliveryService {
1512
private static final String PDF_DOCUMENT_FILE_NAME = "World_Wide_Corp_lorem.pdf";
@@ -42,6 +39,7 @@ public static EnvelopeDefinition makeEnvelope(
4239
String countryCode,
4340
String signersPhoneNumber,
4441
String signerName,
42+
String deliveryMethod,
4543
String ccCountryCode,
4644
String carbonCopyPhoneNumber,
4745
String ccName,
@@ -69,7 +67,7 @@ public static EnvelopeDefinition makeEnvelope(
6967
signer.setRecipientId("1");
7068
signer.setRoutingOrder("1");
7169
signer.setTabs(signerTabs);
72-
signer.setDeliveryMethod("sms");
70+
signer.setDeliveryMethod(deliveryMethod);
7371

7472

7573
// create a cc recipient to receive a copy of the documents, identified by name and phone number
@@ -82,7 +80,7 @@ public static EnvelopeDefinition makeEnvelope(
8280
cc.setPhoneNumber(ccPhoneNumber);
8381
cc.setRecipientId("2");
8482
cc.setRoutingOrder("2");
85-
cc.setDeliveryMethod("sms");
83+
cc.setDeliveryMethod(deliveryMethod);
8684

8785
// The order in the docs array determines the order in the envelope
8886
EnvelopeDefinition envelope = new EnvelopeDefinition();

src/main/webapp/WEB-INF/templates/views/pages/esignature/examples/eg037.jsp

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,13 @@
55
<c:set var="countryCodeInputNumber" value="0" scope="page" />
66
<c:set var="numberInputNumber" value="1" scope="page" />
77
<c:set var="signerNameInputNumber" value="2" scope="page" />
8+
<c:set var="deliveryMethod" value="6" scope="page" />
89
<c:set var="ccCountryCodeInputNumber" value="3" scope="page" />
910
<c:set var="ccNumberInputNumber" value="4" scope="page" />
1011
<c:set var="ccSignerNameInputNumber" value="5" scope="page" />
12+
<c:set var="sms" value="7" scope="page" />
13+
<c:set var="whatsapp" value="8" scope="page" />
14+
1115

1216
<h4>${example.getExampleName()}</h4>
1317
<p>${example.getExampleDescription()}</p>
@@ -22,7 +26,11 @@
2226
</p>
2327

2428
<form class="eg" action="" method="post" data-busy="form">
25-
29+
<div class="form-group">
30+
<label for="deliveryMethod">${example.getForms().get(formNumber).getInputs().get(deliveryMethod).getInputName()}</label><br>
31+
<input type="radio" checked="checked" name="deliveryMethod" id="delivery_method1" value="SMS"/> ${example.getForms().get(formNumber).getInputs().get(sms).getInputName()} &nbsp;
32+
<input type="radio" name="deliveryMethod" id="delivery_method2" value="WhatsApp"/> ${example.getForms().get(formNumber).getInputs().get(whatsapp).getInputName()} <br>
33+
</div>
2634
<div class="form-group">
2735
<label for="countryCode">
2836
${example.getForms().get(formNumber).getInputs().get(countryCodeInputNumber).getInputName()}

0 commit comments

Comments
 (0)