Introduce blame options for rename tracking

Author: Therzok

LibGit2Sharp/BlameHunkCollection.cs

@@ -28,11 +28,21 @@ internal unsafe BlameHunkCollection(Repository repo, RepositoryHandle repoHandle
             var rawopts = new git_blame_options
             {
                 version = 1,
+                FindOptions = new GitDiffFindOptions {
+                    Version = 1,
+                },
                 flags = options.Strategy.ToGitBlameOptionFlags(),
                 min_line = new UIntPtr((uint)options.MinLine),
                 max_line = new UIntPtr((uint)options.MaxLine),
             };
 
+            if (options.FindNoRenames)
+                rawopts.FindOptions.Flags = GitDiffFindFlags.GIT_DIFF_FIND_NO_RENAMES;
+            else if (options.FindExactRenames)
+                rawopts.FindOptions.Flags = GitDiffFindFlags.GIT_DIFF_FIND_EXACT_MATCH_ONLY;
+            else
+                rawopts.FindOptions.Flags = GitDiffFindFlags.GIT_DIFF_FIND_RENAMES;
+
             if (options.StartingAt != null)
             {
                 fixed (byte* p = rawopts.newest_commit.Id)

LibGit2Sharp/BlameOptions.cs

@@ -6,7 +6,7 @@
     public enum BlameStrategy
     {
         /// <summary>
-        /// Track renames of the file, but no block movement.
+        /// Track renames of the file using diff rename detection, but no block movement.
         /// </summary>
         Default,
 
@@ -58,5 +58,15 @@ public sealed class BlameOptions
         /// If this is set to 0, blame ends with the last line in the file.
         /// </summary>
         public int MaxLine { get; set; }
+
+        /// <summary>
+        /// Disables rename heuristics, only matching renames on unmodified files.
+        /// </summary>
+        public bool FindExactRenames { get; set; }
+
+        /// <summary>
+        /// Fully disable rename checking.
+        /// </summary>
+        public bool FindNoRenames { get; set; }
     }
 }

LibGit2Sharp/Core/GitBlame.cs

@@ -44,6 +44,7 @@ internal enum GitBlameOptionFlags
     internal class git_blame_options
     {
         public uint version = 1;
+        public GitDiffFindOptions FindOptions;
         public GitBlameOptionFlags flags;
 
         public UInt16 min_match_characters;

LibGit2Sharp/Core/GitDiff.cs

@@ -350,6 +350,9 @@ enum GitDiffFindFlags
         // turn on all finding features
         GIT_DIFF_FIND_ALL = (0x0ff),
 
+        // does no work trying to find renames
+        GIT_DIFF_FIND_NO_RENAMES = (1 << 8),
+
         // measure similarity ignoring leading whitespace (default)
         GIT_DIFF_FIND_IGNORE_LEADING_WHITESPACE = 0,
         // measure similarity ignoring all whitespace
@@ -367,9 +370,9 @@ enum GitDiffFindFlags
     }
 
     [StructLayout(LayoutKind.Sequential)]
-    internal class GitDiffFindOptions
+    internal struct GitDiffFindOptions
     {
-        public uint Version = 1;
+        public uint Version;
         public GitDiffFindFlags Flags;
         public UInt16 RenameThreshold;
         public UInt16 RenameFromRewriteThreshold;

LibGit2Sharp/Core/NativeMethods.cs

@@ -618,7 +618,12 @@ internal static extern unsafe int git_diff_foreach(
         [DllImport(libgit2, CallingConvention = CallingConvention.Cdecl)]
         internal static extern unsafe int git_diff_find_similar(
             git_diff* diff,
-            GitDiffFindOptions options);
+            IntPtr options);
+
+        [DllImport(libgit2)]
+        internal static extern unsafe int git_diff_find_similar(
+            git_diff* diff,
+            ref GitDiffFindOptions options);
 
         [DllImport(libgit2, CallingConvention = CallingConvention.Cdecl)]
         internal static extern unsafe UIntPtr git_diff_num_deltas(git_diff* diff);

LibGit2Sharp/Core/Proxy.cs

@@ -827,12 +827,18 @@ public static unsafe DiffHandle git_diff_tree_to_workdir(
             }
         }
 
-        public static unsafe void git_diff_find_similar(DiffHandle diff, GitDiffFindOptions options)
+        public static unsafe void git_diff_find_similar(DiffHandle diff, IntPtr options)
         {
             int res = NativeMethods.git_diff_find_similar(diff, options);
             Ensure.ZeroResult(res);
         }
 
+        public static unsafe void git_diff_find_similar(DiffHandle diff, GitDiffFindOptions options)
+        {
+            int res = NativeMethods.git_diff_find_similar(diff, ref options);
+            Ensure.ZeroResult(res);
+        }
+
         public static unsafe int git_diff_num_deltas(DiffHandle diff)
         {
             return (int)NativeMethods.git_diff_num_deltas(diff);

LibGit2Sharp/Diff.cs

@@ -584,7 +584,7 @@ private static void DetectRenames(DiffHandle diffList, CompareOptions compareOpt
             var similarityOptions = (compareOptions == null) ? null : compareOptions.Similarity;
             if (similarityOptions == null || similarityOptions.RenameDetectionMode == RenameDetectionMode.Default)
             {
-                Proxy.git_diff_find_similar(diffList, null);
+                Proxy.git_diff_find_similar(diffList, IntPtr.Zero);
                 return;
             }
 
@@ -595,6 +595,7 @@ private static void DetectRenames(DiffHandle diffList, CompareOptions compareOpt
 
             var opts = new GitDiffFindOptions
             {
+                Version = 1,
                 RenameThreshold = (ushort)similarityOptions.RenameThreshold,
                 RenameFromRewriteThreshold = (ushort)similarityOptions.RenameFromRewriteThreshold,
                 CopyThreshold = (ushort)similarityOptions.CopyThreshold,

LibGit2Sharp/DiffModifiers.cs

@@ -36,5 +36,16 @@ internal enum DiffModifiers
         /// diffing against the working directory.
         /// </summary>
         IncludeIgnored = (1 << 4),
+
+        /// <summary>
+        /// Specifies that no rename heuristics will be used when checking for
+        /// renames, renames being matched only on unmodified renamed files.
+        /// </summary>
+        FindExactRenames = (1 << 5),
+
+        /// <summary>
+        /// Specifies that no renames will be searched for when running blame.
+        /// </summary>
+        FindNoRenames = (1 << 6),
     }
 }