From 2b564e660fe2a82e791e0a6cede35b6455e5da82 Mon Sep 17 00:00:00 2001
From: filzrev <103790468+filzrev@users.noreply.github.com>
Date: Thu, 19 Feb 2026 22:02:25 +0900
Subject: [PATCH 1/2] chore: enable nullable on common.props

---
 build/common.props                                              | 2 +-
 .../BenchmarkDotNet.Samples.FSharp.fsproj                       | 1 -
 samples/BenchmarkDotNet.Samples/BenchmarkDotNet.Samples.csproj  | 1 -
 src/BenchmarkDotNet.Annotations/Attributes/ParamsAttribute.cs   | 2 --
 .../BenchmarkDotNet.Annotations.csproj                          | 1 -
 .../BenchmarkDotNet.Diagnostics.Windows.csproj                  | 1 -
 .../BenchmarkDotNet.Diagnostics.dotMemory.csproj                | 1 -
 .../BenchmarkDotNet.Diagnostics.dotTrace.csproj                 | 1 -
 .../BenchmarkDotNet.Disassembler.csproj                         | 1 -
 .../BenchmarkDotNet.Exporters.Plotting.csproj                   | 1 -
 .../BenchmarkDotNet.TestAdapter.csproj                          | 1 -
 src/BenchmarkDotNet.TestAdapter/VSTestEventProcessor.cs         | 2 --
 src/BenchmarkDotNet.Weaver/BenchmarkDotNet.Weaver.csproj        | 1 -
 src/BenchmarkDotNet/BenchmarkDotNet.csproj                      | 1 -
 tests/Directory.Build.props                                     | 1 -
 15 files changed, 1 insertion(+), 17 deletions(-)

diff --git a/build/common.props b/build/common.props
index 499fddaa11..c52cc134c5 100644
--- a/build/common.props
+++ b/build/common.props
@@ -23,7 +23,7 @@
     <CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)CodingStyle.ruleset</CodeAnalysisRuleSet>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <WarningsNotAsErrors>NU1900</WarningsNotAsErrors>
-    <Nullable Condition="'$(Nullable)' == ''">annotations</Nullable>
+    <Nullable Condition="'$(Nullable)' == ''">enable</Nullable>
     <!-- Suppress warning for nuget package used in old (unsupported) tfm. -->
     <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
   </PropertyGroup>
diff --git a/samples/BenchmarkDotNet.Samples.FSharp/BenchmarkDotNet.Samples.FSharp.fsproj b/samples/BenchmarkDotNet.Samples.FSharp/BenchmarkDotNet.Samples.FSharp.fsproj
index 7fa9d477b9..b607dc88ef 100644
--- a/samples/BenchmarkDotNet.Samples.FSharp/BenchmarkDotNet.Samples.FSharp.fsproj
+++ b/samples/BenchmarkDotNet.Samples.FSharp/BenchmarkDotNet.Samples.FSharp.fsproj
@@ -6,7 +6,6 @@
     <GenerateProgramFile>false</GenerateProgramFile>
     <!-- Disable parallel tests between TargetFrameworks -->
     <TestTfmsInParallel>false</TestTfmsInParallel>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
   <ItemGroup>
     <Compile Include="Program.fs" />
diff --git a/samples/BenchmarkDotNet.Samples/BenchmarkDotNet.Samples.csproj b/samples/BenchmarkDotNet.Samples/BenchmarkDotNet.Samples.csproj
index 1d0f5a3fb5..9df0af8dc9 100644
--- a/samples/BenchmarkDotNet.Samples/BenchmarkDotNet.Samples.csproj
+++ b/samples/BenchmarkDotNet.Samples/BenchmarkDotNet.Samples.csproj
@@ -14,7 +14,6 @@
     <GenerateProgramFile>false</GenerateProgramFile>
     <!-- Disable parallel tests between TargetFrameworks -->
     <TestTfmsInParallel>false</TestTfmsInParallel>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
   <ItemGroup Condition=" '$(TargetFrameworkIdentifier)' == '.NETFramework' ">
     <Reference Include="System.Reflection" />
diff --git a/src/BenchmarkDotNet.Annotations/Attributes/ParamsAttribute.cs b/src/BenchmarkDotNet.Annotations/Attributes/ParamsAttribute.cs
index f10694d9bf..1a461609b5 100644
--- a/src/BenchmarkDotNet.Annotations/Attributes/ParamsAttribute.cs
+++ b/src/BenchmarkDotNet.Annotations/Attributes/ParamsAttribute.cs
@@ -1,7 +1,5 @@
 using System;
 
-#nullable enable
-
 namespace BenchmarkDotNet.Attributes
 {
     [AttributeUsage(AttributeTargets.Field | AttributeTargets.Property)]
diff --git a/src/BenchmarkDotNet.Annotations/BenchmarkDotNet.Annotations.csproj b/src/BenchmarkDotNet.Annotations/BenchmarkDotNet.Annotations.csproj
index d7cf498ccd..e8abc7b93e 100644
--- a/src/BenchmarkDotNet.Annotations/BenchmarkDotNet.Annotations.csproj
+++ b/src/BenchmarkDotNet.Annotations/BenchmarkDotNet.Annotations.csproj
@@ -9,7 +9,6 @@
     <RootNamespace>BenchmarkDotNet</RootNamespace>
     <!-- needed for docfx xref resolver -->
     <ProduceReferenceAssembly>True</ProduceReferenceAssembly>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
   <!-- Settings for PolySharp -->
   <PropertyGroup>
diff --git a/src/BenchmarkDotNet.Diagnostics.Windows/BenchmarkDotNet.Diagnostics.Windows.csproj b/src/BenchmarkDotNet.Diagnostics.Windows/BenchmarkDotNet.Diagnostics.Windows.csproj
index 8c85d98c04..9eaefcdf21 100644
--- a/src/BenchmarkDotNet.Diagnostics.Windows/BenchmarkDotNet.Diagnostics.Windows.csproj
+++ b/src/BenchmarkDotNet.Diagnostics.Windows/BenchmarkDotNet.Diagnostics.Windows.csproj
@@ -7,7 +7,6 @@
     <NoWarn>1701;1702;1705;1591;3001;3003;3002;3009</NoWarn>
     <AssemblyName>BenchmarkDotNet.Diagnostics.Windows</AssemblyName>
     <PackageId>BenchmarkDotNet.Diagnostics.Windows</PackageId>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\BenchmarkDotNet\BenchmarkDotNet.csproj" />
diff --git a/src/BenchmarkDotNet.Diagnostics.dotMemory/BenchmarkDotNet.Diagnostics.dotMemory.csproj b/src/BenchmarkDotNet.Diagnostics.dotMemory/BenchmarkDotNet.Diagnostics.dotMemory.csproj
index 06599ed127..79589f3d1e 100644
--- a/src/BenchmarkDotNet.Diagnostics.dotMemory/BenchmarkDotNet.Diagnostics.dotMemory.csproj
+++ b/src/BenchmarkDotNet.Diagnostics.dotMemory/BenchmarkDotNet.Diagnostics.dotMemory.csproj
@@ -6,7 +6,6 @@
         <AssemblyTitle>BenchmarkDotNet.Diagnostics.dotMemory</AssemblyTitle>
         <AssemblyName>BenchmarkDotNet.Diagnostics.dotMemory</AssemblyName>
         <PackageId>BenchmarkDotNet.Diagnostics.dotMemory</PackageId>
-        <Nullable>enable</Nullable>
     </PropertyGroup>
 
     <ItemGroup>
diff --git a/src/BenchmarkDotNet.Diagnostics.dotTrace/BenchmarkDotNet.Diagnostics.dotTrace.csproj b/src/BenchmarkDotNet.Diagnostics.dotTrace/BenchmarkDotNet.Diagnostics.dotTrace.csproj
index 1e1e4efc08..04f5308a46 100644
--- a/src/BenchmarkDotNet.Diagnostics.dotTrace/BenchmarkDotNet.Diagnostics.dotTrace.csproj
+++ b/src/BenchmarkDotNet.Diagnostics.dotTrace/BenchmarkDotNet.Diagnostics.dotTrace.csproj
@@ -6,7 +6,6 @@
         <AssemblyTitle>BenchmarkDotNet.Diagnostics.dotTrace</AssemblyTitle>
         <AssemblyName>BenchmarkDotNet.Diagnostics.dotTrace</AssemblyName>
         <PackageId>BenchmarkDotNet.Diagnostics.dotTrace</PackageId>
-        <Nullable>enable</Nullable>
     </PropertyGroup>
 
     <ItemGroup>
diff --git a/src/BenchmarkDotNet.Disassembler/BenchmarkDotNet.Disassembler.csproj b/src/BenchmarkDotNet.Disassembler/BenchmarkDotNet.Disassembler.csproj
index 1d00745955..0d25872d95 100644
--- a/src/BenchmarkDotNet.Disassembler/BenchmarkDotNet.Disassembler.csproj
+++ b/src/BenchmarkDotNet.Disassembler/BenchmarkDotNet.Disassembler.csproj
@@ -8,7 +8,6 @@
     <PlatformTarget>x64</PlatformTarget>
     <!-- This project is only used for debugging the disassembler, it's not included in any BenchmarkDotNet packages. -->
     <IsPackable>false</IsPackable>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
   <PropertyGroup>
     <RootNamespace>BenchmarkDotNet.Disassembler</RootNamespace>
diff --git a/src/BenchmarkDotNet.Exporters.Plotting/BenchmarkDotNet.Exporters.Plotting.csproj b/src/BenchmarkDotNet.Exporters.Plotting/BenchmarkDotNet.Exporters.Plotting.csproj
index be74aa9216..1bd710c9d2 100644
--- a/src/BenchmarkDotNet.Exporters.Plotting/BenchmarkDotNet.Exporters.Plotting.csproj
+++ b/src/BenchmarkDotNet.Exporters.Plotting/BenchmarkDotNet.Exporters.Plotting.csproj
@@ -8,7 +8,6 @@
     <RootNamespace>BenchmarkDotNet.Exporters.Plotting</RootNamespace>
     <!-- needed for docfx xref resolver -->
     <ProduceReferenceAssembly>True</ProduceReferenceAssembly>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\BenchmarkDotNet\BenchmarkDotNet.csproj" />
diff --git a/src/BenchmarkDotNet.TestAdapter/BenchmarkDotNet.TestAdapter.csproj b/src/BenchmarkDotNet.TestAdapter/BenchmarkDotNet.TestAdapter.csproj
index 2c888be468..9986e62410 100644
--- a/src/BenchmarkDotNet.TestAdapter/BenchmarkDotNet.TestAdapter.csproj
+++ b/src/BenchmarkDotNet.TestAdapter/BenchmarkDotNet.TestAdapter.csproj
@@ -6,7 +6,6 @@
     <AssemblyName>BenchmarkDotNet.TestAdapter</AssemblyName>
     <PackageId>BenchmarkDotNet.TestAdapter</PackageId>
     <ProduceReferenceAssembly>True</ProduceReferenceAssembly>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <!-- Use minimum supported LTSC version of Visual Studio 2022 -->
diff --git a/src/BenchmarkDotNet.TestAdapter/VSTestEventProcessor.cs b/src/BenchmarkDotNet.TestAdapter/VSTestEventProcessor.cs
index 913f16e621..29926280ad 100644
--- a/src/BenchmarkDotNet.TestAdapter/VSTestEventProcessor.cs
+++ b/src/BenchmarkDotNet.TestAdapter/VSTestEventProcessor.cs
@@ -15,8 +15,6 @@
 using System.Text;
 using System.Threading;
 
-#nullable enable
-
 namespace BenchmarkDotNet.TestAdapter
 {
     /// <summary>
diff --git a/src/BenchmarkDotNet.Weaver/BenchmarkDotNet.Weaver.csproj b/src/BenchmarkDotNet.Weaver/BenchmarkDotNet.Weaver.csproj
index cda2b1138f..36701f6acc 100644
--- a/src/BenchmarkDotNet.Weaver/BenchmarkDotNet.Weaver.csproj
+++ b/src/BenchmarkDotNet.Weaver/BenchmarkDotNet.Weaver.csproj
@@ -17,7 +17,6 @@ then run `build.cmd pack-weaver`.
     <DelaySign>false</DelaySign>
     <!-- Fix error NU5017: Cannot create a package that has no dependencies nor content. -->
     <IsPackable Condition="'$(IsFullPack)' == 'true'">false</IsPackable>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/BenchmarkDotNet/BenchmarkDotNet.csproj b/src/BenchmarkDotNet/BenchmarkDotNet.csproj
index c4d8b56639..51f6032aa6 100644
--- a/src/BenchmarkDotNet/BenchmarkDotNet.csproj
+++ b/src/BenchmarkDotNet/BenchmarkDotNet.csproj
@@ -10,7 +10,6 @@
     <RootNamespace>BenchmarkDotNet</RootNamespace>
     <!-- needed for docfx xref resolver -->
     <ProduceReferenceAssembly>True</ProduceReferenceAssembly>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
   <ItemGroup>
     <EmbeddedResource Include="Templates\*" Exclude="bin\**;obj\**;**\*.xproj;packages\**;@(EmbeddedResource)" />
diff --git a/tests/Directory.Build.props b/tests/Directory.Build.props
index 9a41ba3d45..dd5ce8b594 100644
--- a/tests/Directory.Build.props
+++ b/tests/Directory.Build.props
@@ -1,6 +1,5 @@
 <Project>
   <PropertyGroup>
-    <Nullable>enable</Nullable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <IsPackable>false</IsPackable>
   </PropertyGroup>

From 3c723aa7105a65b2ebd5d71c4fa3526b6a85d2cc Mon Sep 17 00:00:00 2001
From: filzrev <103790468+filzrev@users.noreply.github.com>
Date: Thu, 19 Feb 2026 22:20:31 +0900
Subject: [PATCH 2/2] chore: remove condition that is not currently used

---
 build/common.props | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build/common.props b/build/common.props
index c52cc134c5..64a49f3d7d 100644
--- a/build/common.props
+++ b/build/common.props
@@ -23,7 +23,7 @@
     <CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)CodingStyle.ruleset</CodeAnalysisRuleSet>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <WarningsNotAsErrors>NU1900</WarningsNotAsErrors>
-    <Nullable Condition="'$(Nullable)' == ''">enable</Nullable>
+    <Nullable>enable</Nullable>
     <!-- Suppress warning for nuget package used in old (unsupported) tfm. -->
     <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
   </PropertyGroup>