Feedback: DisposeAsyncCore might throw.

ilonatommy · ilonatommy · commit b6959c689a6a · 2025-12-08T14:36:18.000+01:00
diff --git a/src/Components/Components/src/OwningComponentBase.cs b/src/Components/Components/src/OwningComponentBase.cs
@@ -74,8 +74,14 @@ async ValueTask IAsyncDisposable.DisposeAsync()
     {
         if (!IsDisposed)
         {
-            await DisposeAsyncCore().ConfigureAwait(false);
-            Dispose(disposing: true);
+            try
+            {
+                await DisposeAsyncCore().ConfigureAwait(false);
+            }
+            finally
+            {
+                Dispose(disposing: true);
+            }
         }
         GC.SuppressFinalize(this);
     }

Original file line number	Diff line number	Diff line change
`@@ -74,8 +74,14 @@ async ValueTask IAsyncDisposable.DisposeAsync()`
`74`	`74`	`{`
`75`	`75`	`if (!IsDisposed)`
`76`	`76`	`{`
`77`		`- await DisposeAsyncCore().ConfigureAwait(false);`
`78`		`- Dispose(disposing: true);`
	`77`	`+ try`
	`78`	`+ {`
	`79`	`+ await DisposeAsyncCore().ConfigureAwait(false);`
	`80`	`+ }`
	`81`	`+ finally`
	`82`	`+ {`
	`83`	`+ Dispose(disposing: true);`
	`84`	`+ }`
`79`	`85`	`}`
`80`	`86`	`GC.SuppressFinalize(this);`
`81`	`87`	`}`