Skip to content

[DO NOT MERGE] Install scripts update validation PR #64672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ellahathaway wants to merge 1 commit into from
+2 −2
Closed

[DO NOT MERGE] Install scripts update validation PR #64672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/common/tools.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ function GetDotNetInstallScript([string] $dotnetRoot) {
if ($shouldDownload) {
Create-Directory $dotnetRoot
$ProgressPreference = 'SilentlyContinue' # Don't display the console progress UI - it's a huge perf hit
$uri = "https://builds.dotnet.microsoft.com/dotnet/scripts/$dotnetInstallScriptVersion/dotnet-install.ps1"
$uri = "https://raw.githubusercontent.com/dotnet/install-scripts/main/src/dotnet-install.ps1"
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new URL points to the main branch of the install-scripts repository, which means it will always fetch the latest version without any version control. This removes the ability to use a specific, stable version of the install script via the $dotnetInstallScriptVersion variable (defined at line 46 with default 'v1').

Consider one of the following approaches:

  1. If the new repository supports versioned paths, use a URL like https://raw.githubusercontent.com/dotnet/install-scripts/$dotnetInstallScriptVersion/src/dotnet-install.ps1 to maintain version control
  2. If version control is no longer needed, remove the now-unused $dotnetInstallScriptVersion variable from line 46 and update the comment at lines 44-45

Copilot uses AI. Check for mistakes.

Retry({
Write-Host "GET $uri"
Expand Down
2 changes: 1 addition & 1 deletion eng/common/tools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ function with_retries {
function GetDotNetInstallScript {
local root=$1
local install_script="$root/dotnet-install.sh"
local install_script_url="https://builds.dotnet.microsoft.com/dotnet/scripts/$dotnetInstallScriptVersion/dotnet-install.sh"
local install_script_url="https://raw.githubusercontent.com/dotnet/install-scripts/main/src/dotnet-install.sh"
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new URL points to the main branch of the install-scripts repository, which means it will always fetch the latest version without any version control. This removes the ability to use a specific, stable version of the install script via the dotnetInstallScriptVersion variable (defined at line 61 with default 'v1').

Consider one of the following approaches:

  1. If the new repository supports versioned paths, use a URL like https://raw.githubusercontent.com/dotnet/install-scripts/$dotnetInstallScriptVersion/src/dotnet-install.sh to maintain version control
  2. If version control is no longer needed, remove the now-unused dotnetInstallScriptVersion variable from line 61 and update the comment at lines 59-60

Copilot uses AI. Check for mistakes.
local timestamp_file="$root/.dotnet-install.timestamp"
local should_download=false

Expand Down
Loading