Do TODOs

Author: brianrourkeboll

src/Compiler/Driver/GraphChecking/FileContentMapping.fs

@@ -408,9 +408,7 @@ let visitSynExpr (e: SynExpr) : FileContentEntry list =
                         | SynExprRecordFieldOrSpread.Field(SynExprRecordField(fieldName = (si, _); expr = expr)) ->
                             yield! visitSynLongIdent si
                             yield! collectFromOption visitSynExpr expr
-                        | SynExprRecordFieldOrSpread.Spread _ ->
-                            // TODO.
-                            ()
+                        | SynExprRecordFieldOrSpread.Spread(spread = SynExprSpread(expr = expr)) -> yield! visitSynExpr expr
                 ]
 
             match baseInfo, copyInfo with

src/Compiler/Service/FSharpParseFileResults.fs

@@ -639,7 +639,7 @@ type FSharpParseFileResults(diagnostics: FSharpDiagnostic[], input: ParsedInput,
                                     fs
                                     |> List.choose (function
                                         | SynExprRecordFieldOrSpread.Field(SynExprRecordField(expr = e)) -> e
-                                        | _ -> None (* TODO. *) )
+                                        | SynExprRecordFieldOrSpread.Spread(spread = SynExprSpread(expr = e)) -> Some e)
                                 )
 
                         | SynExpr.AnonRecd(copyInfo = copyExprOpt; recordFields = fs) ->
@@ -650,9 +650,9 @@ type FSharpParseFileResults(diagnostics: FSharpDiagnostic[], input: ParsedInput,
                             yield!
                                 walkExprs (
                                     fs
-                                    |> List.choose (function
-                                        | SynExprAnonRecordFieldOrSpread.Field(SynExprAnonRecordField(_, _, e, _), _) -> Some e
-                                        | SynExprAnonRecordFieldOrSpread.Spread _ -> None (* TODO. *) )
+                                    |> List.map (function
+                                        | SynExprAnonRecordFieldOrSpread.Field(SynExprAnonRecordField(_, _, e, _), _)
+                                        | SynExprAnonRecordFieldOrSpread.Spread(spread = SynExprSpread(expr = e)) -> e)
                                 )
 
                         | SynExpr.ObjExpr(argOptions = args; bindings = bs; members = ms; extraImpls = is) ->

src/Compiler/Service/ServiceInterfaceStubGenerator.fs

@@ -854,7 +854,7 @@ module InterfaceStubGenerator =
                     List.tryPick
                         (function
                         | SynExprRecordFieldOrSpread.Field(SynExprRecordField(expr = e)) -> Option.bind walkExpr e
-                        | _ -> None (* TODO. *) )
+                        | SynExprRecordFieldOrSpread.Spread(spread = SynExprSpread(expr = e)) -> walkExpr e)
                         fields
 
                 | SynExpr.New(_, _synType, synExpr, _range) -> walkExpr synExpr

src/Compiler/Service/ServiceParseTreeWalk.fs

@@ -463,9 +463,8 @@ module SyntaxTraversal =
                             | SynExprAnonRecordFieldOrSpread.Field(SynExprAnonRecordField(field, _, x, _), _) ->
                                 yield dive () field.Range (fun () -> visitor.VisitRecordField(path, copyOpt |> Option.map fst, Some field))
                                 yield dive x x.Range traverseSynExpr
-                            | SynExprAnonRecordFieldOrSpread.Spread _ ->
-                                // TODO.
-                                ()
+                            | SynExprAnonRecordFieldOrSpread.Spread(spread = SynExprSpread(expr = expr)) ->
+                                yield dive expr expr.Range traverseSynExpr
                     ]
                     |> pick expr
 
@@ -919,7 +918,7 @@ module SyntaxTraversal =
             |> List.tryPick (function
                 | SynFieldOrSpread.Field(SynField(attributes = attributes)) ->
                     attributeApplicationDives path attributes |> pick m attributes
-                | SynFieldOrSpread.Spread _ -> None) // TODO.
+                | SynFieldOrSpread.Spread _ -> None)
             |> Option.orElseWith (fun () -> visitor.VisitRecordDefn(path, fieldsAndSpreads, m))
 
         and traverseEnumDefn path cases m =

src/Compiler/Service/ServiceParsedInputOps.fs

@@ -823,7 +823,7 @@ module ParsedInput =
                     fields
                     |> List.tryPick (function
                         | SynExprRecordFieldOrSpread.Field(SynExprRecordField(expr = e)) -> e |> Option.bind (walkExprWithKind parentKind)
-                        | _ -> None (* TODO. *) ))
+                        | SynExprRecordFieldOrSpread.Spread(spread = SynExprSpread(expr = e)) -> walkExprWithKind parentKind e))
 
             | SynExpr.ObjExpr(objType = ty; bindings = bindings; members = ms; extraImpls = ifaces) ->
                 let bindings = unionBindingAndMembers bindings ms

src/Compiler/Service/ServiceStructure.fs

@@ -442,7 +442,7 @@ module Structure =
                 recordFields
                 |> List.choose (function
                     | SynExprRecordFieldOrSpread.Field(SynExprRecordField(expr = e)) -> e
-                    | _ -> None (* TODO. *) )
+                    | SynExprRecordFieldOrSpread.Spread(spread = SynExprSpread(expr = e)) -> Some e)
                 |> List.iter parseExpr
                 // exclude the opening `{` and closing `}` of the record from collapsing
                 let m = Range.modBoth 1 1 r

src/Compiler/Service/SynExpr.fs

@@ -1114,7 +1114,6 @@ module SynExpr =
                     | SynExprRecordFieldOrSpread.Field(SynExprRecordField(
                         expr = Some(SynExpr.Paren(expr = Is inner)); blockSeparator = Some _)) :: SynExprRecordFieldOrSpread.Field(SynExprRecordField(
                           fieldName = SynLongIdent(id = id :: _), _)) :: _ -> problematic inner.Range id.idRange
-                    // TODO: Spreads?
                     | _ :: recordFields -> loop recordFields
 
                 loop recordFields