Merge pull request #126 from drivecore/feature/117-config-validation

Add validation for config keys and filter list output

Author: bhouston

packages/cli/src/commands/config.ts

@@ -59,15 +59,24 @@ export const command: CommandModule<SharedOptions, ConfigOptions> = {
     if (argv.command === 'list') {
       logger.info('Current configuration:');
       const defaultConfig = getDefaultConfig();
-      Object.entries(config).forEach(([key, value]) => {
+
+      // Get all valid config keys
+      const validKeys = Object.keys(defaultConfig);
+
+      // Filter and sort config entries
+      const configEntries = Object.entries(config)
+        .filter(([key]) => validKeys.includes(key))
+        .sort(([keyA], [keyB]) => keyA.localeCompare(keyB));
+
+      // Display config entries with default indicators
+      configEntries.forEach(([key, value]) => {
         const isDefault =
           JSON.stringify(value) ===
           JSON.stringify(defaultConfig[key as keyof typeof defaultConfig]);
-        const valueDisplay = chalk.green(value);
-        const statusIndicator = isDefault
-          ? chalk.dim(' (default)')
-          : chalk.blue(' (custom)');
-        logger.info(`  ${key}: ${valueDisplay}${statusIndicator}`);
+        const valueDisplay = isDefault
+          ? chalk.dim(`${value} (default)`)
+          : chalk.green(value);
+        logger.info(`  ${key}: ${valueDisplay}`);
       });
       return;
     }
@@ -101,6 +110,16 @@ export const command: CommandModule<SharedOptions, ConfigOptions> = {
         return;
       }
 
+      // Validate that the key exists in default config
+      const defaultConfig = getDefaultConfig();
+      if (!(argv.key in defaultConfig)) {
+        logger.error(`Invalid configuration key '${argv.key}'`);
+        logger.info(
+          `Valid configuration keys: ${Object.keys(defaultConfig).join(', ')}`,
+        );
+        return;
+      }
+
       // Parse the value based on current type or infer boolean/number
       let parsedValue: string | boolean | number = argv.value;
 

packages/cli/tests/commands/config.test.ts

@@ -65,6 +65,37 @@ describe.skip('Config Command', () => {
       interactive: false,
       command: 'list',
     } as any);
+    it('should filter out invalid config keys in list command', async () => {
+      // Mock getConfig to return config with invalid keys
+      vi.mocked(getConfig).mockReturnValue({
+        githubMode: false,
+        invalidKey: 'some value',
+      } as any);
+
+      // Mock getDefaultConfig to return only valid keys
+      vi.mocked(getDefaultConfig).mockReturnValue({
+        githubMode: false,
+      });
+
+      await command.handler!({
+        _: ['config', 'config', 'list'],
+        logLevel: 'info',
+        interactive: false,
+        command: 'list',
+      } as any);
+
+      expect(getConfig).toHaveBeenCalled();
+      expect(getDefaultConfig).toHaveBeenCalled();
+
+      // Should show the valid key
+      expect(mockLogger.info).toHaveBeenCalledWith(
+        expect.stringContaining('githubMode'),
+      );
+
+      // Should not show the invalid key
+      const infoCallArgs = mockLogger.info.mock.calls.flat();
+      expect(infoCallArgs.join()).not.toContain('invalidKey');
+    });
 
     expect(getConfig).toHaveBeenCalled();
     expect(mockLogger.info).toHaveBeenCalledWith('Current configuration:');
@@ -147,6 +178,21 @@ describe.skip('Config Command', () => {
     );
   });
 
+  it('should validate key exists in default config for set command', async () => {
+    await command.handler!({
+      _: ['config', 'config', 'set', 'invalidKey', 'value'],
+      logLevel: 'info',
+      interactive: false,
+      command: 'set',
+      key: 'invalidKey',
+      value: 'value',
+    } as any);
+
+    expect(mockLogger.error).toHaveBeenCalledWith(
+      expect.stringContaining('Invalid configuration key'),
+    );
+  });
+
   it('should handle unknown command', async () => {
     await command.handler!({
       _: ['config', 'config', 'unknown'],